public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug tree-optimization/112856] New: [14 regression] ICE when building clustal-omega
@ 2023-12-05  5:59 sjames at gcc dot gnu.org
  2023-12-05  7:01 ` [Bug tree-optimization/112856] " sjames at gcc dot gnu.org
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: sjames at gcc dot gnu.org @ 2023-12-05  5:59 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112856

            Bug ID: 112856
           Summary: [14 regression] ICE when building clustal-omega
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: sjames at gcc dot gnu.org
  Target Milestone: ---

Created attachment 56803
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=56803&action=edit
hhalign.ii.xz

I've never heard of 'clustal-omega' either but it's one of our packages and it
broke, so...

Originally reported downstream in Gentoo at https://bugs.gentoo.org/919165 by
Toralf Förster.

```
# x86_64-pc-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I../../src -fno-strict-aliasing
-DCLUSTALO -DCLUSTALO_NOFILE -DDEFAULT_FILTER=90 -fopenmp -O3 -march=native
-fno-semantic-interposition -pipe -Wa,-O2 -Wa,-mtune=znver2
-fcf-protection=none -fdiagnostics-color=always -fdiagnostics-urls=never
-frecord-gcc-switches -ggdb3 -c hhalign.cpp  -fPIC -DPIC -o .libs/hhalign.o
In file included from hhalign.cpp:70:
hhhmm-C.h: In member function ‘void HMM::UseSecStrucDependentGapPenalties()’:
hhhmm-C.h:1748:16: warning: writing 1 byte into a region of size 0
[-Wstringop-overflow=]
 1748 |   iis[0]=iis[L]=0;
      |          ~~~~~~^~
hhhmm-C.h:1734:17: note: at offset [-2147483648, -1] into destination object
‘iis’ of size [0, 2147483647]
 1734 |   unsigned char iis[par.maxResLen]; // inside-integer array
      |                 ^~~
during GIMPLE pass: ch_vect
In file included from hhalign.cpp:75:
hhhitlist-C.h: In member function ‘void HitList::SVD(double**, int, double*,
double**)’:
hhhitlist-C.h:2919:1: internal compiler error: in check_loop_closed_ssa_def, at
tree-ssa-loop-manip.cc:647
 2919 | HitList::SVD(double **A, int n, double w[], double **V)
      | ^~~~~~~
0x55fb54b5dd71 check_loop_closed_ssa_def
       
/usr/src/debug/sys-devel/gcc-14.0.0_pre20231203/gcc-14-20231203/gcc/tree-ssa-loop-manip.cc:647
0x55fb54b5dd71 check_loop_closed_ssa_bb
       
/usr/src/debug/sys-devel/gcc-14.0.0_pre20231203/gcc-14-20231203/gcc/tree-ssa-loop-manip.cc:661
0x55fb54b5d787 verify_loop_closed_ssa(bool, loop*)
       
/usr/src/debug/sys-devel/gcc-14.0.0_pre20231203/gcc-14-20231203/gcc/tree-ssa-loop-manip.cc:697
0x55fb5449dd08 execute_function_todo
       
/usr/src/debug/sys-devel/gcc-14.0.0_pre20231203/gcc-14-20231203/gcc/passes.cc:2106
0x55fb5449dd08 do_per_function
       
/usr/src/debug/sys-devel/gcc-14.0.0_pre20231203/gcc-14-20231203/gcc/passes.cc:1687
0x55fb5449dd08 execute_todo
       
/usr/src/debug/sys-devel/gcc-14.0.0_pre20231203/gcc-14-20231203/gcc/passes.cc:2142
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://bugs.gentoo.org/> for instructions.
```

I can reproduce with 'g++ -c hhalign.ii -O3 -fno-strict-aliasing'.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug tree-optimization/112856] [14 regression] ICE when building clustal-omega
  2023-12-05  5:59 [Bug tree-optimization/112856] New: [14 regression] ICE when building clustal-omega sjames at gcc dot gnu.org
@ 2023-12-05  7:01 ` sjames at gcc dot gnu.org
  2023-12-05  7:02 ` [Bug tree-optimization/112856] [14 regression] ICE when building clustal-omega in check_loop_closed_ssa_def, at tree-ssa-loop-manip.cc:647 sjames at gcc dot gnu.org
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: sjames at gcc dot gnu.org @ 2023-12-05  7:01 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112856

--- Comment #1 from Sam James <sjames at gcc dot gnu.org> ---
reduced C version:
```
double *SVD_A_0;
int SVD_i, SVD_j, SVD_k, SVD_n;
double SVD_f;
void SVD() {
  SVD_i = SVD_n - 1;
  for (; SVD_i; SVD_i--) {
    for (; SVD_j; SVD_j++) {
      SVD_f = SVD_k = SVD_i;
      for (; SVD_k < SVD_n; SVD_k++)
        SVD_A_0[SVD_k] += SVD_f;
    }
    SVD_j = SVD_i;
    for (; SVD_j < SVD_n; SVD_j++)
      ;
  }
}

```
fails with just gcc -O3.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug tree-optimization/112856] [14 regression] ICE when building clustal-omega in check_loop_closed_ssa_def, at tree-ssa-loop-manip.cc:647
  2023-12-05  5:59 [Bug tree-optimization/112856] New: [14 regression] ICE when building clustal-omega sjames at gcc dot gnu.org
  2023-12-05  7:01 ` [Bug tree-optimization/112856] " sjames at gcc dot gnu.org
@ 2023-12-05  7:02 ` sjames at gcc dot gnu.org
  2023-12-05  7:52 ` rguenth at gcc dot gnu.org
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: sjames at gcc dot gnu.org @ 2023-12-05  7:02 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112856

Sam James <sjames at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hubicka at gcc dot gnu.org
            Summary|[14 regression] ICE when    |[14 regression] ICE when
                   |building clustal-omega      |building clustal-omega in
                   |                            |check_loop_closed_ssa_def,
                   |                            |at
                   |                            |tree-ssa-loop-manip.cc:647

--- Comment #2 from Sam James <sjames at gcc dot gnu.org> ---
Possibly a dupe of PR109689.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug tree-optimization/112856] [14 regression] ICE when building clustal-omega in check_loop_closed_ssa_def, at tree-ssa-loop-manip.cc:647
  2023-12-05  5:59 [Bug tree-optimization/112856] New: [14 regression] ICE when building clustal-omega sjames at gcc dot gnu.org
  2023-12-05  7:01 ` [Bug tree-optimization/112856] " sjames at gcc dot gnu.org
  2023-12-05  7:02 ` [Bug tree-optimization/112856] [14 regression] ICE when building clustal-omega in check_loop_closed_ssa_def, at tree-ssa-loop-manip.cc:647 sjames at gcc dot gnu.org
@ 2023-12-05  7:52 ` rguenth at gcc dot gnu.org
  2023-12-05 13:16 ` cvs-commit at gcc dot gnu.org
  2023-12-05 13:16 ` rguenth at gcc dot gnu.org
  4 siblings, 0 replies; 6+ messages in thread
From: rguenth at gcc dot gnu.org @ 2023-12-05  7:52 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112856

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2023-12-05
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org
   Target Milestone|---                         |14.0
             Status|UNCONFIRMED                 |ASSIGNED

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
Testing patch.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug tree-optimization/112856] [14 regression] ICE when building clustal-omega in check_loop_closed_ssa_def, at tree-ssa-loop-manip.cc:647
  2023-12-05  5:59 [Bug tree-optimization/112856] New: [14 regression] ICE when building clustal-omega sjames at gcc dot gnu.org
                   ` (2 preceding siblings ...)
  2023-12-05  7:52 ` rguenth at gcc dot gnu.org
@ 2023-12-05 13:16 ` cvs-commit at gcc dot gnu.org
  2023-12-05 13:16 ` rguenth at gcc dot gnu.org
  4 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-12-05 13:16 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112856

--- Comment #4 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:8ff02df62935429d8956361cfdb897122492523d

commit r14-6181-g8ff02df62935429d8956361cfdb897122492523d
Author: Richard Biener <rguenther@suse.de>
Date:   Tue Dec 5 08:50:57 2023 +0100

    tree-optimization/112856 - fix LC SSA after loop header copying

    When loop header copying unloops loops we have to possibly fixup
    LC SSA.  I've take the opportunity to streamline the unloop_loops
    API, removing the use of a ivcanon local global variable.

            PR tree-optimization/109689
            PR tree-optimization/112856
            * cfgloopmanip.h (unloop_loops): Adjust API.
            * tree-ssa-loop-ivcanon.cc (unloop_loops): Take edges_to_remove
            as parameter.
            (canonicalize_induction_variables): Adjust.
            (tree_unroll_loops_completely): Likewise.
            * tree-ssa-loop-ch.cc (ch_base::copy_headers): Rewrite into
            LC SSA if we unlooped some loops and we are in LC SSA.

            * gcc.dg/torture/pr109689.c: New testcase.
            * gcc.dg/torture/pr112856.c: Likewise.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug tree-optimization/112856] [14 regression] ICE when building clustal-omega in check_loop_closed_ssa_def, at tree-ssa-loop-manip.cc:647
  2023-12-05  5:59 [Bug tree-optimization/112856] New: [14 regression] ICE when building clustal-omega sjames at gcc dot gnu.org
                   ` (3 preceding siblings ...)
  2023-12-05 13:16 ` cvs-commit at gcc dot gnu.org
@ 2023-12-05 13:16 ` rguenth at gcc dot gnu.org
  4 siblings, 0 replies; 6+ messages in thread
From: rguenth at gcc dot gnu.org @ 2023-12-05 13:16 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112856

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2023-12-05 13:16 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-05  5:59 [Bug tree-optimization/112856] New: [14 regression] ICE when building clustal-omega sjames at gcc dot gnu.org
2023-12-05  7:01 ` [Bug tree-optimization/112856] " sjames at gcc dot gnu.org
2023-12-05  7:02 ` [Bug tree-optimization/112856] [14 regression] ICE when building clustal-omega in check_loop_closed_ssa_def, at tree-ssa-loop-manip.cc:647 sjames at gcc dot gnu.org
2023-12-05  7:52 ` rguenth at gcc dot gnu.org
2023-12-05 13:16 ` cvs-commit at gcc dot gnu.org
2023-12-05 13:16 ` rguenth at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).