From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 546F63858C60; Wed, 17 Jan 2024 21:07:30 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 546F63858C60
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1705525651;
	bh=DThwa1W0zeHCisCZtoAEmbhboIz4xh1auyACmmLUiDg=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=j0OCrhbyE8rSG1w7ec3mfsj1iR5ZzUU75bMPCjfIv/wC1ne+Agi7Nz3o9RoB2F/4T
	 0FLqUf8tM4AL6XFSZ5638C4kfoBcEVFNhhltS2uW6LAPpYCIAo9Puw7Pi4VsyqksBX
	 cj9Tv68rOOD9UOjbcB97gfOU1iwATDOBACxjuvC8=
From: "iains at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/112862] [14 regression] gfortran.dg coarray tests FAIL
 on macOS 12+
Date: Wed, 17 Jan 2024 21:07:29 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 14.0
X-Bugzilla-Keywords: testsuite-fail
X-Bugzilla-Severity: normal
X-Bugzilla-Who: iains at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 14.0
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-112862-4-LoIKHNbfaa@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-112862-4@http.gcc.gnu.org/bugzilla/>
References: <bug-112862-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D112862

--- Comment #3 from Iain Sandoe <iains at gcc dot gnu.org> ---
OK. So I realise the reason you see this and I wasn't: I have the habit of
installing before running the testsuite.  When I test uninstalled, then I g=
et
the issue.

... the subsequent work reveals that we are not setting the
"ENABLE_DARWIN_AT_RPATH" in gcc/site.exp.  Somehow an AC_SUBST has been dro=
pped
on the way.  However, that is actually fixable with a small change to
gcc/Makefile.in.


... then we have to add -Bpath/to/libatomic/.libs conditionally on
ENABLE_DARWIN_AT_RPATH (in gfortran.exp) (not hard since ENABLE_DARWIN_AT_R=
PATH
is a global)

Now I have a concern that we have instances of -Bpath/to/libsomething/.libs
that are present to allow for specs substitution and we also need them for
providing run paths at test time.  BUT, we do not want duplicates (since, t=
hat
triggers a different warning for some Xcode versions, and is inefficient an=
yway
- albeit probably a very minor contribution to testing time).

So I think that gcc/lib/gfortran.exp needs to have the library -B/-L additi=
ons
structured so that only one set gets added.  I'll draft a patch for you to =
try.=