public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "grantrwittmann at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/112870] incorrect jmp when using goto on a function, causing infinite loop
Date: Tue, 05 Dec 2023 19:01:21 +0000	[thread overview]
Message-ID: <bug-112870-4-Wmhq7CXQK9@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-112870-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112870

--- Comment #2 from Grant Wittman <grantrwittmann at gmail dot com> ---
(In reply to Andrew Pinski from comment #1)
> This is all undefined behavior.
> 
> 
> Please read
> https://gcc.gnu.org/onlinedocs/gcc-13.2.0/gcc/Labels-as-Values.html .
> 
> Specifically:
> You may not use this mechanism to jump to code in a different function.

I think I might get what you mean by 'undefined behavior', but this result is
predictable. I know that specific code snippet does not work, but it was the
shortest example I could make that would recreate the error.

Additionally, that doesn't explain why the last instruction is compiled
completely differently when the line `void* label_var = &&label;`, is removed.
I understand that the `label` is also removed from compilation but I can still
just use this code and it compiles correctly:

void function() {
    return;
}

int main() {
    goto *&function;
}

Again this code does not run without a segfault, but it compiles correctly.

If I force the compiler to add the labels into the assembly, it will still
compile correctly:

void function() {
    return;
}

int one = 1;

int main() {
    if(one) goto end;
label:
    goto *&function;
end:
    if(!one) goto label;
    return 0;
}

which compiles to

function:
        push    rbp
        mov     rbp, rsp
        nop
        pop     rbp
        ret
one:
        .long   1
main:
        push    rbp
        mov     rbp, rsp
        mov     eax, DWORD PTR one[rip]
        test    eax, eax
        jne     .L9
        nop
        jmp     .L4
.L10:
        nop
.L4:
        mov     eax, OFFSET FLAT:function
        jmp     rax
.L9:
        nop
        mov     eax, DWORD PTR one[rip]
        test    eax, eax
        je      .L10
        mov     eax, 0
        pop     rbp
        ret

But by adding that declaration of `label_var` back, it breaks again

void function() {
    return;
}

int one = 1;

int main() {
    void* label_var = &&label; // <-- ADDED STATEMENT
    if(one) goto end;
label:
    goto *&function;
end:
    if(!one) goto label;
    return 0;
}

which compiles to 

function:
        push    rbp
        mov     rbp, rsp
        nop
        pop     rbp
        ret
one:
        .long   1
main:
        push    rbp
        mov     rbp, rsp
        mov     QWORD PTR [rbp-8], OFFSET FLAT:.L4
        mov     eax, DWORD PTR one[rip]
        test    eax, eax
        jne     .L9
.L4:
        nop
        jmp     .L4 ; <-- GOTO STATEMENT INFINITE LOOP AGAIN
.L9:
        nop
        mov     eax, DWORD PTR one[rip]
        test    eax, eax
        jne     .L6
        jmp     .L4
.L6:
        mov     eax, 0
        pop     rbp
        ret

  parent reply	other threads:[~2023-12-05 19:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-05 18:41 [Bug c/112870] New: " grantrwittmann at gmail dot com
2023-12-05 18:44 ` [Bug c/112870] " pinskia at gcc dot gnu.org
2023-12-05 19:01 ` grantrwittmann at gmail dot com [this message]
2023-12-05 19:04 ` pinskia at gcc dot gnu.org
2024-03-16 17:58 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-112870-4-Wmhq7CXQK9@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).