public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug modula2/112893] gm2 fails to detect procedure address actual parameter is incompatible with cardinal formal parameter
Date: Sat, 20 Apr 2024 13:36:04 +0000	[thread overview]
Message-ID: <bug-112893-4-2A9Cm4sTdr@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-112893-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112893

--- Comment #9 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Gaius Mulley <gaius@gcc.gnu.org>:

https://gcc.gnu.org/g:f9a48fe7032d9894e88d0d121ba6f75b08ea5dcb

commit r14-10053-gf9a48fe7032d9894e88d0d121ba6f75b08ea5dcb
Author: Gaius Mulley <gaiusmod2@gmail.com>
Date:   Sat Apr 20 14:35:18 2024 +0100

    PR modula2/112893 full type checking between proctype and procedure not
implemented

    This patch implements full type checking between proctype and procedures.
    The change implements an associated proc type built for each
    procedure.  M2Check.mod will request GetProcedureProcType if it encounters
    a procedure.  Before this patch a procedure was associated with the type
    ADDRESS in the type checking module M2Check.  The
    gm2/pim/pass/proccard.mod have been corrected now this assumption has
    been removed.

    gcc/m2/ChangeLog:

            PR modula2/112893
            * gm2-compiler/M2Check.mod (GetProcedureProcType): Import.
            (getType): Return value using GetProcedureProcType if sym is a
            procedure.
            * gm2-compiler/M2Range.mod (FoldTypeExpr): Remove quad if
            expression is type compatible.
            * gm2-compiler/SymbolTable.def (GetProcedureProcType): New
            procedure function.
            * gm2-compiler/SymbolTable.mod (Procedure): Add ProcedureType.
            (MakeProcedure): Initialize ProcedureType.
            (PutParam): Call AddProcedureProcTypeParam.
            (PutVarParam): Call AddProcedureProcTypeParam.
            (AddProcedureProcTypeParam): New procedure.
            (GetProcedureProcType): New procedure function.

    gcc/testsuite/ChangeLog:

            PR modula2/112893
            * gm2/pim/pass/another.mod: Correct bug exposed by type checker.
            Swap ProcA and ProcB assignments.
            * gm2/pim/pass/proccard.mod: Use VAL to convert procedure into a
            cardinal.
            * gm2/iso/const/fail/castproctype.mod: New test.
            * gm2/pim/fail/badproctype.mod: New test.

    Signed-off-by: Gaius Mulley <gaiusmod2@gmail.com>

  parent reply	other threads:[~2024-04-20 13:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-07  2:23 [Bug modula2/112893] New: " gaius at gcc dot gnu.org
2023-12-07  2:24 ` [Bug modula2/112893] " gaius at gcc dot gnu.org
2023-12-07  2:26 ` gaius at gcc dot gnu.org
2023-12-07  2:44 ` gaius at gcc dot gnu.org
2023-12-07 12:58 ` gaius at gcc dot gnu.org
2023-12-07 13:11 ` cvs-commit at gcc dot gnu.org
2023-12-07 13:12 ` gaius at gcc dot gnu.org
2023-12-08 14:39 ` gaius at gcc dot gnu.org
2024-04-19 22:39 ` gaius at gcc dot gnu.org
2024-04-20 13:36 ` cvs-commit at gcc dot gnu.org [this message]
2024-04-20 13:40 ` gaius at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-112893-4-2A9Cm4sTdr@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).