From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 6FE74385841C; Sun,  7 Jan 2024 10:52:26 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6FE74385841C
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1704624746;
	bh=iY1y3eVD3MliC1inpL8EAkwSlF0iue9WhloKBw11Rww=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=ksfm4JnazI91BGk+qSFxp78NNWll6u4XueTHz9rv3/wz+sSxSteayRvh2fnxDkbWw
	 LJLv7rmexFPCZUUXoQZIregC9Bhfux+XITLQ+bR5YLBh83ar0ZGM7FuDrpYsjbifWv
	 +EfrgI7Mk1SN3s3vvaHEnKCAwwk4wihe4jhgU0Dc=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/112899] odr-using constexpr static data member of class
 exported from module results in linker error
Date: Sun, 07 Jan 2024 10:52:25 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 13.2.0
X-Bugzilla-Keywords: link-failure
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-112899-4-olwQWp8Onc@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-112899-4@http.gcc.gnu.org/bugzilla/>
References: <bug-112899-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D112899

--- Comment #2 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Nathaniel Shead <nshead@gcc.gnu.org>:

https://gcc.gnu.org/g:a71c3977d24722ac8ee28d8844c4f96a151f75ab

commit r14-6979-ga71c3977d24722ac8ee28d8844c4f96a151f75ab
Author: Nathaniel Shead <nathanieloshead@gmail.com>
Date:   Wed Jan 3 09:28:43 2024 +1100

    c++: Fix ICE when writing nontrivial variable initializers

    The attached testcase Patrick found in PR c++/112899 ICEs because it is
    attempting to write a variable initializer that is no longer in the
    static_aggregates map.

    The issue is that, for non-header modules, the loop in
    c_parse_final_cleanups prunes the static_aggregates list, which means
    that by the time we get to emitting module information those
    initialisers have been lost.

    However, we don't actually need to write non-trivial initialisers for
    non-header modules, because they've already been emitted as part of the
    module TU itself.  Instead let's just only write the initializers from
    header modules (which skipped writing them in c_parse_final_cleanups).

    gcc/cp/ChangeLog:

            * module.cc (trees_out::write_var_def): Only write initializers
            in header modules.

    gcc/testsuite/ChangeLog:

            * g++.dg/modules/init-5_a.C: New test.
            * g++.dg/modules/init-5_b.C: New test.

    Signed-off-by: Nathaniel Shead <nathanieloshead@gmail.com>=