From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 15D983861813; Tue,  9 Jan 2024 13:37:33 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 15D983861813
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1704807454;
	bh=g2hecgiX36JLIMJqGblJ0437x0cUB+KcziNPC21ok8A=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=AvdVc4rjfw9X9jMS2NklPSVl1PJw+G5ojlavBuleK8LoTHPj8wfVK1HRQDllsDt0V
	 G6MM6Xj+G5dRDgFi5EDfWulxo4M73j8v9jc1CkhPwdEipC4ixFSoj+UzFPKy3sU2Of
	 OCRlSSnsANXmUSwSxqtNUAbxkV/aQZwVA3OGicxM=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug modula2/112920] gm2 hangs in the type resolver
Date: Tue, 09 Jan 2024 13:37:32 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: modula2
X-Bugzilla-Version: 14.0
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: gaius at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-112920-4-fpfGXpVePE@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-112920-4@http.gcc.gnu.org/bugzilla/>
References: <bug-112920-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D112920

--- Comment #3 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Gaius Mulley <gaius@gcc.gnu.org>:

https://gcc.gnu.org/g:e3632a18d1e0b94b4c7b99a512b19c830ed3b228

commit r14-7064-ge3632a18d1e0b94b4c7b99a512b19c830ed3b228
Author: Gaius Mulley <gaiusmod2@gmail.com>
Date:   Tue Jan 9 13:36:44 2024 +0000

    PR modula2/112920 cc1gm2 hangs in the type resolver

    This patch contains a fix to gcc/m2/gm2-compiler/M2GCCDeclare.mod.
    The fix introduces a group of sets which can be compared.  The resolver
    will loop until there is no change in all sets within the group.
    Since symbols migrate from set to set without ever looping this
    will never hang.  Previously only the number of elements in a set
    were compared which resulted in a infinite spin.

    gcc/m2/ChangeLog:

            PR modula2/112920
            * gm2-compiler/M2GCCDeclare.mod (Group): New declaration.
            Import MakeSubrange, MakeConstVar, MakeConstLit and DivTrunc.
            (FreeGroup): New declaration.
            (GlobalGroup): New declaration.
            (ToBeSolvedByQuads): Remove.
            (NilTypedArrays): Remove.
            (PartiallyDeclared): Remove.
            (HeldByAlignment): Remove.
            (FinishedAlignment): Remove.
            (ToDoList): Remove.
            (DebugSet): Re-format.
            (DebugNumber): Re-format.
            (DebugSetNumbers): Reference sets using GlobalGroup.
            (AddSymToWatch): Re-format.
            (WatchIncludeList): Reference sets using GlobalGroup.
            (WatchRemoveList): Reference sets using GlobalGroup.
            (NewGroup): New procedure.
            (DisposeGroup): New procedure.
            (InitGroup): New procedure.
            (KillGroup): New procedure.
            (DupGroup): New procedure.
            (EqualGroup): New procedure.
            (LookupSet): New procedure.
            (CanDeclareTypePartially): Reference sets using GlobalGroup.
            (CompletelyResolved): Reference sets using GlobalGroup.
            (IsNilTypedArrays): Reference sets using GlobalGroup.
            (IsFullyDeclared): Reference sets using GlobalGroup.
            (IsPartiallyDeclared): Reference sets using GlobalGroup.
            (IsPartiallyOrFullyDeclared): Reference sets using GlobalGroup.
            (DeclareTypeConstFully): Reference sets using GlobalGroup.
            (bodyl): Remove.
            (Body): Use bodyt and to lookup the required set.
            (ForeachTryDeclare): Remove parameter l.  Lookup set instead.
            (DeclareOutstandingTypes): Add new rules setarraynul and setful=
ly.
            Reference sets using GlobalGroup.
            (ActivateWatch): New procedure.
            (DeclareTypesConstantsProceduresInRange): Re-written to check
            group change.
            (DeclareTypesConstantsProcedures): Re-written to check
            group change.
            (DeclareBoolean): Reference sets using GlobalGroup.
            (DeclarePackedBoolean): Ditto.
            (DeclareDefaultConstants): Ditto.
            (FreeGroup): Initialized.
            (GlobalGroup): Ditto.
            * gm2-compiler/Sets.def (EqualSet): New procedure function.
            Remove export qualified list of identifiers.
            * gm2-compiler/Sets.mod (EqualSet): New procedure function.

    Signed-off-by: Gaius Mulley <gaiusmod2@gmail.com>=