public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/112938] ice with -fstrub=internal
Date: Tue, 16 Apr 2024 05:02:30 +0000	[thread overview]
Message-ID: <bug-112938-4-viek2GUL85@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-112938-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112938

--- Comment #11 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Alexandre Oliva <aoliva@gcc.gnu.org>:

https://gcc.gnu.org/g:c39dc5bb65c492fafc5a0fde83708b8d24e0338d

commit r14-9985-gc39dc5bb65c492fafc5a0fde83708b8d24e0338d
Author: Alexandre Oliva <oliva@adacore.com>
Date:   Tue Apr 16 01:24:59 2024 -0300

    [strub] improve handling of indirected volatile parms [PR112938]

    The earlier patch for PR112938 arranged for volatile parms to be made
    indirect in internal strub wrapped bodies.

    The first problem that remained, more evident, was that the indirected
    parameter remained volatile, despite the indirection, but it wasn't
    regimplified, so indirecting it was malformed gimple.

    Regimplifying turned out not to be needed.  The best course of action
    was to drop the volatility from the by-reference parm, that was being
    unexpectedly inherited from the original volatile parm.

    That exposed another problem: the dereferences would then lose their
    volatile status, so we had to bring volatile back to them.


    for  gcc/ChangeLog

            PR middle-end/112938
            * ipa-strub.cc (pass_ipa_strub::execute): Drop volatility from
            indirected parm.
            (maybe_make_indirect): Restore volatility in dereferences.

    for  gcc/testsuite/ChangeLog

            PR middle-end/112938
            * g++.dg/strub-internal-pr112938.cc: New.

  parent reply	other threads:[~2024-04-16  5:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-09 11:45 [Bug c++/112938] New: " dcb314 at hotmail dot com
2023-12-09 11:48 ` [Bug c++/112938] " dcb314 at hotmail dot com
2023-12-09 20:17 ` [Bug middle-end/112938] " pinskia at gcc dot gnu.org
2023-12-11 16:25 ` aoliva at gcc dot gnu.org
2023-12-12  2:13 ` aoliva at gcc dot gnu.org
2023-12-14 13:41 ` cvs-commit at gcc dot gnu.org
2023-12-14 13:41 ` cvs-commit at gcc dot gnu.org
2023-12-20  0:22 ` aoliva at gcc dot gnu.org
2024-02-27 11:23 ` dcb314 at hotmail dot com
2024-02-28  8:20 ` dcb314 at hotmail dot com
2024-03-08 11:05 ` aoliva at gcc dot gnu.org
2024-04-16  5:02 ` cvs-commit at gcc dot gnu.org [this message]
2024-04-18  9:51 ` aoliva at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-112938-4-viek2GUL85@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).