public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libquadmath/112963] [14 Regression] Incorrect linking of libquadmath since r14-4863
Date: Mon, 11 Dec 2023 22:50:04 +0000	[thread overview]
Message-ID: <bug-112963-4-MuDKgydjfE@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-112963-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112963

--- Comment #13 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
I've already started testing the:
2023-12-11  Jakub Jelinek  <jakub@redhat.com>

        PR libquadmath/112963
        * configure.ac (LIBM): Readd AC_CHECK_LIBM-like check without doing
        AC_CHECK_LIB in it.
        * configure: Regenerated.
        * Makefile.in: Regenerated.

--- libquadmath/configure.ac.jj 2023-11-02 07:49:22.120795297 +0100
+++ libquadmath/configure.ac    2023-12-11 19:03:50.823783215 +0100
@@ -122,6 +122,20 @@ esac
 AC_SUBST(toolexecdir)
 AC_SUBST(toolexeclibdir)

+# AC_CHECK_LIBM variant which avoids AC_CHECK_LIB which doesn't work
+# on bare metal.  In the past we've used -lm in Makefile.am unconditionally,
+# let's use it there unless target knows it doesn't need that.
+LIBM=
+case $host in
+*-*-beos* | *-*-cegcc* | *-*-cygwin* | *-*-haiku* | *-*-pw32* | *-*-darwin*)
+  # These system don't have libm, or don't need it
+  ;;
+*)
+  LIBM=-lm
+  ;;
+esac
+AC_SUBST([LIBM])
+
 AC_CHECK_HEADERS(fenv.h langinfo.h locale.h wchar.h wctype.h limits.h ctype.h
printf.h errno.h)
 LIBQUAD_CHECK_MATH_H_SIGNGAM

--- libquadmath/configure.jj    2023-11-02 07:49:22.119795311 +0100
+++ libquadmath/configure       2023-12-11 19:04:04.239598274 +0100
@@ -644,6 +644,7 @@ LIBQUAD_USE_SYMVER_GNU_FALSE
 LIBQUAD_USE_SYMVER_GNU_TRUE
 LIBQUAD_USE_SYMVER_FALSE
 LIBQUAD_USE_SYMVER_TRUE
+LIBM
 toolexeclibdir
 toolexecdir
 MAINT
@@ -10921,7 +10922,7 @@ else
   lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
   lt_status=$lt_dlunknown
   cat > conftest.$ac_ext <<_LT_EOF
-#line 10924 "configure"
+#line 10925 "configure"
 #include "confdefs.h"

 #if HAVE_DLFCN_H
@@ -11027,7 +11028,7 @@ else
   lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
   lt_status=$lt_dlunknown
   cat > conftest.$ac_ext <<_LT_EOF
-#line 11030 "configure"
+#line 11031 "configure"
 #include "confdefs.h"

 #if HAVE_DLFCN_H
@@ -12260,6 +12261,20 @@ esac



+# AC_CHECK_LIBM variant which avoids AC_CHECK_LIB which doesn't work
+# on bare metal.  In the past we've used -lm in Makefile.am unconditionally,
+# let's use it there unless target knows it doesn't need that.
+LIBM=
+case $host in
+*-*-beos* | *-*-cegcc* | *-*-cygwin* | *-*-haiku* | *-*-pw32* | *-*-darwin*)
+  # These system don't have libm, or don't need it
+  ;;
+*)
+  LIBM=-lm
+  ;;
+esac
+
+
 for ac_header in fenv.h langinfo.h locale.h wchar.h wctype.h limits.h ctype.h
printf.h errno.h
 do :
   as_ac_Header=`$as_echo "ac_cv_header_$ac_header" | $as_tr_sh`
--- libquadmath/Makefile.in.jj  2023-11-02 07:49:22.108795464 +0100
+++ libquadmath/Makefile.in     2023-12-11 19:04:57.971857555 +0100
@@ -355,6 +355,7 @@ INSTALL_SCRIPT = @INSTALL_SCRIPT@
 INSTALL_STRIP_PROGRAM = @INSTALL_STRIP_PROGRAM@
 LD = @LD@
 LDFLAGS = @LDFLAGS@
+LIBM = @LIBM@
 LIBOBJS = @LIBOBJS@
 LIBS = @LIBS@
 LIBTOOL = @LIBTOOL@

version.

  parent reply	other threads:[~2023-12-11 22:50 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-11 15:23 [Bug libquadmath/112963] New: " jakub at gcc dot gnu.org
2023-12-11 15:23 ` [Bug libquadmath/112963] " jakub at gcc dot gnu.org
2023-12-11 15:43 ` schwab@linux-m68k.org
2023-12-11 15:44 ` iains at gcc dot gnu.org
2023-12-11 15:46 ` iains at gcc dot gnu.org
2023-12-11 15:53 ` pinskia at gcc dot gnu.org
2023-12-11 15:59 ` jakub at gcc dot gnu.org
2023-12-11 16:05 ` iains at gcc dot gnu.org
2023-12-11 16:19 ` jakub at gcc dot gnu.org
2023-12-11 16:27 ` iains at gcc dot gnu.org
2023-12-11 16:31 ` jakub at gcc dot gnu.org
2023-12-11 16:35 ` jakub at gcc dot gnu.org
2023-12-11 16:40 ` iains at gcc dot gnu.org
2023-12-11 22:48 ` iains at gcc dot gnu.org
2023-12-11 22:50 ` jakub at gcc dot gnu.org [this message]
2023-12-12  8:07 ` cvs-commit at gcc dot gnu.org
2023-12-12  8:10 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-112963-4-MuDKgydjfE@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).