From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id DE2A23858034; Wed,  6 Mar 2024 16:58:55 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DE2A23858034
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1709744335;
	bh=w3YnrPSrm8sT5vroJCCo8cn1NJzZZE8bpo+l14cOmsY=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=aP2bjIMSOhm1MAO5Z7yBz/xg7DWi2DF2a7FKJ3hPkpWFH7dgD+rXOpZVm9KSusCSe
	 PBH0mP8/a36siHHsnyDgJgIERSoymwFGEXQbHNDHbneWKGK+/tRfHwLIC/fOp/t0dr
	 kI/szWVl5Mgae9i5d7Sd2B0t5y2LezhHiFRcIoIs=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/113001] [14 Regression] RISCV Zicond ICE: in
 extract_insn, at recog.cc:2812 with -O2 rv64gcv_zicond
Date: Wed, 06 Mar 2024 16:58:55 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 14.0
X-Bugzilla-Keywords: ice-on-valid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P4
X-Bugzilla-Assigned-To: law at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 14.0
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-113001-4-PuC30UgDMW@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-113001-4@http.gcc.gnu.org/bugzilla/>
References: <bug-113001-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D113001

--- Comment #4 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jeff Law <law@gcc.gnu.org>:

https://gcc.gnu.org/g:10cbfcd60f9e5bdbe486e1c0192e0f168d899b77

commit r14-9341-g10cbfcd60f9e5bdbe486e1c0192e0f168d899b77
Author: Jeff Law <jlaw@ventanamicro.com>
Date:   Wed Mar 6 09:50:44 2024 -0700

    [PR target/113001] Fix incorrect operand swapping in conditional move

    This bug totally fell off my radar.  Sorry about that.

    We have some special casing the conditional move expander to simplify a
    conditional move when comparing a register against zero and that same
register
    is one of the arms.

    Specifically a (eq (reg) (const_int 0)) where reg is also the true arm =
or
(ne
    (reg) (const_int 0)) where reg is the false arm need not use the fully
    generalized conditional move, thus saving an instruction for those case=
s.

    In the NE case we swapped the operands, but didn't swap the condition,
which
    led to the ICE due to an unrecognized pattern.  THe backend actually has
    distinct patterns for those two cases.  So swapping the operands is nei=
ther
    needed nor advisable.

    Regression tested on rv64gc and verified the new tests pass.

    Pushing to the trunk.

            PR target/113001
            PR target/112871
    gcc/
            * config/riscv/riscv.cc (expand_conditional_move): Do not swap
            operands when the comparison operand is the same as the false
            arm for a NE test.

    gcc/testsuite
            * gcc.target/riscv/zicond-ice-3.c: New test.
            * gcc.target/riscv/zicond-ice-4.c: New test.=