public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/113002] ICE in commit_one_edge_insertion, at cfgrtl.cc:2095 with new -finline-stringops
Date: Wed, 20 Dec 2023 08:19:40 +0000	[thread overview]
Message-ID: <bug-113002-4-gNmHjwBb00@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-113002-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113002

--- Comment #4 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Alexandre Oliva <aoliva@gcc.gnu.org>:

https://gcc.gnu.org/g:672db38c6f0723ca57fe8ff4c43422341e7fb857

commit r14-6735-g672db38c6f0723ca57fe8ff4c43422341e7fb857
Author: Alexandre Oliva <oliva@adacore.com>
Date:   Tue Dec 19 22:17:42 2023 -0300

    -finline-stringops: allow expansion into edges [PR113002]

    Builtin expanders for memset and memcpy may involve conditionals and
    loops, but their sequences may be end up emitted in edges.  Alas,
    commit_one_edge_insertion rejects sequences that end with a jump, a
    requirement that makes sense for insertions after expand, but not so
    much during expand.

    During expand, jumps may appear in the middle of the insert sequence
    as much as in the end, and it's only after committing edge insertions
    out of PHI nodes that we go through the entire function splitting
    blocks where needed, so relax the assert in commit_one_edge_insertion
    so that jumps are accepted during expand even at the end of the
    sequence.


    for  gcc/ChangeLog

            PR rtl-optimization/113002
            * cfgrtl.cc (commit_one_edge_insertion): Tolerate jumps in the
            inserted sequence during expand.

    for  gcc/testsuite/ChangeLog

            PR rtl-optimization/113002
            * gcc.dg/vect/pr113002.c: New.

  parent reply	other threads:[~2023-12-20  8:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-13 19:36 [Bug rtl-optimization/113002] New: " mjires at suse dot cz
2023-12-14  9:31 ` [Bug rtl-optimization/113002] " fkastl at suse dot cz
2023-12-20  1:43 ` aoliva at gcc dot gnu.org
2023-12-20  2:07 ` aoliva at gcc dot gnu.org
2023-12-20  8:19 ` cvs-commit at gcc dot gnu.org [this message]
2023-12-21  3:49 ` aoliva at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-113002-4-gNmHjwBb00@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).