public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "lipeng.zhu at intel dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug testsuite/113005] 'libgomp.fortran/rwlock_1.f90', 'libgomp.fortran/rwlock_3.f90' execution test timeouts
Date: Mon, 22 Jan 2024 01:02:35 +0000	[thread overview]
Message-ID: <bug-113005-4-gL2qMNIoJD@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-113005-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113005

--- Comment #14 from Lipeng Zhu <lipeng.zhu at intel dot com> ---
(In reply to Lipeng Zhu from comment #13)
> OK, I think I find the root cause of this error, when thread number greater
> than 1000, the file_name = 1000_tst.dat, character(11) will overflow. This
> will generate the same file_name like ***_tst.dat. 
> 
> diff --git a/libgomp/testsuite/libgomp.fortran/rwlock_1.f90
> b/libgomp/testsuite/libgomp.fortran/rwlock_1.f90
> index f90ecbeb00f..1c271ae031d 100644
> --- a/libgomp/testsuite/libgomp.fortran/rwlock_1.f90
> +++ b/libgomp/testsuite/libgomp.fortran/rwlock_1.f90
> @@ -7,13 +7,12 @@ program main
>    use omp_lib
>    implicit none
>    integer:: unit_number, v1, v2, i
> -  character(11) :: file_name
> +  character(16) :: file_name
>    character(3) :: async = "no"
>    !$omp parallel private (unit_number, v1, v2, file_name, async, i)
>      do i = 0, 100
>        unit_number = 10 + omp_get_thread_num ()
> -      write (file_name, "(I3, A)") unit_number, "_tst.dat"
> -      file_name = adjustl(file_name)
> +      write (file_name, "(I5.5, A)") unit_number, "_tst.dat"
>        open (unit_number, file=file_name, asynchronous="yes")
>        ! call inquire with file parameter to test find_file in unix.c
>        inquire (file=file_name, asynchronous=async)


Hi Thomas,

Can you help to verify if this draft patch will fix the error on your side?

      parent reply	other threads:[~2024-01-22  1:02 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-13 20:46 [Bug libfortran/113005] New: " tschwinge at gcc dot gnu.org
2023-12-21 11:41 ` [Bug testsuite/113005] " tschwinge at gcc dot gnu.org
2023-12-21 11:47 ` jakub at gcc dot gnu.org
2023-12-21 11:50 ` jakub at gcc dot gnu.org
2023-12-22  6:52 ` lipeng.zhu at intel dot com
2023-12-22  8:48 ` jakub at gcc dot gnu.org
2023-12-22  8:59 ` jakub at gcc dot gnu.org
2023-12-22  9:02 ` jakub at gcc dot gnu.org
2023-12-22  9:04 ` jakub at gcc dot gnu.org
2023-12-22  9:59 ` lipeng.zhu at intel dot com
2023-12-22 11:14 ` jakub at gcc dot gnu.org
2023-12-25  2:55 ` lipeng.zhu at intel dot com
2023-12-25  6:22 ` lipeng.zhu at intel dot com
2023-12-25  7:31 ` lipeng.zhu at intel dot com
2024-01-22  1:02 ` lipeng.zhu at intel dot com [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-113005-4-gL2qMNIoJD@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).