From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id A493A385841C; Wed, 10 Jan 2024 09:10:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A493A385841C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1704877831; bh=9Dq3+DwPyAUwNOqHxAw+aRN/pHQ3GIzUHDswocFYzgQ=; h=From:To:Subject:Date:In-Reply-To:References:From; b=Uvzn503F0YTq0n2IabnZpbRHd0koh55nGj8/Ii4PkkRuCv8vwoi034JrH4osDskS3 5ixsYCb6B38fgcyP1km11G6w40iBsZPkgRZdIqwBgPEDcjd5TN9XKzK9CbcleyaxDM MN1k3PN21JtTE+AMD81R/jyFMZzqubnghX17F8aU= From: "rguenth at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug target/113059] [14 regression] fftw fails tests for -O3 -m32 -march=znver2 since r14-6210-ge44ed92dbbe9d4 Date: Wed, 10 Jan 2024 09:10:27 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: target X-Bugzilla-Version: 14.0 X-Bugzilla-Keywords: wrong-code X-Bugzilla-Severity: normal X-Bugzilla-Who: rguenth at gcc dot gnu.org X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: P1 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: 14.0 X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D113059 --- Comment #11 from Richard Biener --- IMHO REG_UNUSED notes should stay correct or be removed. Instead of a full solution can we just wipe them in postreload-cse as we know that pass will break them? Any user then should recompute the notes. Originally pass properties were thought of a vehicle indicating these kind of IL features, = so we could add PROP_rtl_unused_notes and if not set treat them as possibly invalid when present (instead of actively wiping them), and when a pass requires them re-compute them. The problem with properties is that they are always set/unset irrespective of whether a pass did something destroying it. That could be circumvented by postreload-cse only clearing the flag when it does something. Not (re-)using pass properties for this but a flag in struct function works as well of course (or treat it as part of the DF state).=