public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/113062] [14 Regression][aarch64] ICE in fuse_pair, at config/aarch64/aarch64-ldp-fusion.cc:1456 since r14-6605-gc0911c6b357ba9
Date: Wed, 20 Dec 2023 09:41:35 +0000	[thread overview]
Message-ID: <bug-113062-4-vtuMzx2PSd@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-113062-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113062

--- Comment #4 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Alex Coplan <acoplan@gcc.gnu.org>:

https://gcc.gnu.org/g:f5213759a7e0efc4ca7bbb484bab94ca19bc1b5d

commit r14-6740-gf5213759a7e0efc4ca7bbb484bab94ca19bc1b5d
Author: Alex Coplan <alex.coplan@arm.com>
Date:   Wed Dec 20 09:39:29 2023 +0000

    aarch64: Validate register operands early in ldp fusion pass [PR113062]

    We were missing validation of the candidate register operands in the
    ldp/stp pass.  I was relying on recog rejecting such cases when we
    formed the final pair insn, but the testcase shows that with
    -fharden-conditionals we attempt to combine two insns with asm_operands,
    both containing mem rtxes.  This then trips the assert:

    gcc_assert (change->new_uses.is_valid ());

    in the stp case as we aren't expecting to have (distinct) uses of mem in
    the candidate stores.

    While doing this I noticed that it seems more natural to have the
    initial definition of mem_size closer to its first use in track_access,
    so I moved that down.

    gcc/ChangeLog:

            PR target/113062
            * config/aarch64/aarch64-ldp-fusion.cc
            (ldp_bb_info::track_access): Punt on accesses with invalid
            register operands, move definition of mem_size closer to its
            first use.

    gcc/testsuite/ChangeLog:

            PR target/113062
            * gcc.dg/pr113062.c: New test.

  parent reply	other threads:[~2023-12-20  9:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-18 11:24 [Bug target/113062] New: " mjires at suse dot cz
2023-12-18 11:28 ` [Bug target/113062] " acoplan at gcc dot gnu.org
2023-12-18 12:13 ` rguenth at gcc dot gnu.org
2023-12-18 15:36 ` acoplan at gcc dot gnu.org
2023-12-19  9:27 ` acoplan at gcc dot gnu.org
2023-12-20  9:41 ` cvs-commit at gcc dot gnu.org [this message]
2023-12-20  9:42 ` acoplan at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-113062-4-vtuMzx2PSd@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).