From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id D923F3861855; Wed, 20 Dec 2023 09:41:36 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D923F3861855
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1703065296;
	bh=1PV0DDpEtOtaM1eJEZJeBocytWlZKsYV5SveAe+P6zQ=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=PGqOTgt6HpfCUmWpClR8hbTiqGVF4cq1/uH10u+3QPGQikGSYVatpsQp2tV7VlGxI
	 Kal4HyH7tAVmtWu6l7lOPoePXg8iDhXaurHtR/b8i6gL8QeMCKth3JM2pRdgNTbcfw
	 JYiQZvTJ+hb2aQlpfDAL/1689KEVhPdkTMsz+FY8=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/113062] [14 Regression][aarch64] ICE in fuse_pair, at
 config/aarch64/aarch64-ldp-fusion.cc:1456 since r14-6605-gc0911c6b357ba9
Date: Wed, 20 Dec 2023 09:41:35 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 14.0
X-Bugzilla-Keywords: ice-on-valid-code, patch
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: acoplan at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 14.0
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-113062-4-vtuMzx2PSd@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-113062-4@http.gcc.gnu.org/bugzilla/>
References: <bug-113062-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D113062

--- Comment #4 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Alex Coplan <acoplan@gcc.gnu.org>:

https://gcc.gnu.org/g:f5213759a7e0efc4ca7bbb484bab94ca19bc1b5d

commit r14-6740-gf5213759a7e0efc4ca7bbb484bab94ca19bc1b5d
Author: Alex Coplan <alex.coplan@arm.com>
Date:   Wed Dec 20 09:39:29 2023 +0000

    aarch64: Validate register operands early in ldp fusion pass [PR113062]

    We were missing validation of the candidate register operands in the
    ldp/stp pass.  I was relying on recog rejecting such cases when we
    formed the final pair insn, but the testcase shows that with
    -fharden-conditionals we attempt to combine two insns with asm_operands,
    both containing mem rtxes.  This then trips the assert:

    gcc_assert (change->new_uses.is_valid ());

    in the stp case as we aren't expecting to have (distinct) uses of mem in
    the candidate stores.

    While doing this I noticed that it seems more natural to have the
    initial definition of mem_size closer to its first use in track_access,
    so I moved that down.

    gcc/ChangeLog:

            PR target/113062
            * config/aarch64/aarch64-ldp-fusion.cc
            (ldp_bb_info::track_access): Punt on accesses with invalid
            register operands, move definition of mem_size closer to its
            first use.

    gcc/testsuite/ChangeLog:

            PR target/113062
            * gcc.dg/pr113062.c: New test.=