public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/113064] assignement from temporary sometimes invokes copy-assign instead of move-assign operator
Date: Wed, 03 Jan 2024 20:43:46 +0000	[thread overview]
Message-ID: <bug-113064-4-oCimR83Fme@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-113064-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113064

--- Comment #7 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Patrick Palka <ppalka@gcc.gnu.org>:

https://gcc.gnu.org/g:1c522c9eafa5b86b78cd7b3044e120762fb4c879

commit r14-6899-g1c522c9eafa5b86b78cd7b3044e120762fb4c879
Author: Patrick Palka <ppalka@redhat.com>
Date:   Wed Jan 3 15:43:28 2024 -0500

    c++: bad direct reference binding via conv fn [PR113064]

    When computing a direct reference binding via a conversion function
    yields a bad conversion, reference_binding incorrectly commits to that
    conversion instead of trying a conversion via a temporary.  This causes
    us to reject the first testcase because the bad direct conversion to B&&
    via the && conversion operator prevents us from considering the good
    conversion via the & conversion operator and a temporary.  (Similar
    story for the second testcase.)

    This patch fixes this by making reference_binding not prematurely commit
    to such a bad direct conversion.  We still fall back to it if using a
    temporary also fails (otherwise the diagnostic for cpp0x/explicit7.C
    regresses).

            PR c++/113064

    gcc/cp/ChangeLog:

            * call.cc (reference_binding): Still try a conversion via a
            temporary if a direct conversion was bad.

    gcc/testsuite/ChangeLog:

            * g++.dg/cpp0x/rv-conv4.C: New test.
            * g++.dg/cpp0x/rv-conv5.C: New test.

  parent reply	other threads:[~2024-01-03 20:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-18 12:04 [Bug c++/113064] New: " m.cencora at gmail dot com
2023-12-18 12:41 ` [Bug c++/113064] " m.cencora at gmail dot com
2023-12-18 13:00 ` m.cencora at gmail dot com
2023-12-18 19:58 ` mpolacek at gcc dot gnu.org
2023-12-19  9:10 ` m.cencora at gmail dot com
2023-12-19 11:39 ` m.cencora at gmail dot com
2023-12-19 15:54 ` mpolacek at gcc dot gnu.org
2024-01-03 20:43 ` cvs-commit at gcc dot gnu.org [this message]
2024-01-03 22:35 ` ppalka at gcc dot gnu.org
2024-01-03 22:36 ` ppalka at gcc dot gnu.org
2024-01-03 22:50 ` ppalka at gcc dot gnu.org
2024-01-04  8:24 ` m.cencora at gmail dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-113064-4-oCimR83Fme@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).