public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/113089] [14 Regression][aarch64] ICE in process_uses_of_deleted_def, at rtl-ssa/changes.cc:252 since r14-6605-gc0911c6b357ba9
Date: Tue, 23 Jan 2024 16:51:08 +0000	[thread overview]
Message-ID: <bug-113089-4-DBo5LcjTIP@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-113089-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113089

--- Comment #15 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Alex Coplan <acoplan@gcc.gnu.org>:

https://gcc.gnu.org/g:3d82ebb696f50f02c6519c368118a019a460fa9e

commit r14-8370-g3d82ebb696f50f02c6519c368118a019a460fa9e
Author: Alex Coplan <alex.coplan@arm.com>
Date:   Tue Jan 16 21:20:45 2024 +0000

    aarch64: Fix up debug uses in ldp/stp pass [PR113089]

    As the PR shows, we were missing code to update debug uses in the
    load/store pair fusion pass.  This patch fixes that.

    The patch tries to give a complete treatment of the debug uses that will
    be affected by the changes we make, and in particular makes an effort to
    preserve debug info where possible, e.g. when re-ordering an update of
    a base register by a constant over a debug use of that register.  When
    re-ordering loads over a debug use of a transfer register, we reset the
    debug insn.  Likewise when re-ordering stores over debug uses of mem.

    While doing this I noticed that try_promote_writeback used a strange
    choice of move_range for the pair insn, in that it chose the previous
    nondebug insn instead of the insn itself.  Since the insn is being
    changed, these move ranges are equivalent (at least in terms of nondebug
    insn placement as far as RTL-SSA is concerned), but I think it is more
    natural to choose the pair insn itself.  This is needed to avoid
    incorrectly updating some debug uses.

    gcc/ChangeLog:

            PR target/113089
            * config/aarch64/aarch64-ldp-fusion.cc (reset_debug_use): New.
            (fixup_debug_use): New.
            (fixup_debug_uses_trailing_add): New.
            (fixup_debug_uses): New. Use it ...
            (ldp_bb_info::fuse_pair): ... here.
            (try_promote_writeback): Call fixup_debug_uses_trailing_add to
            fix up debug uses of the base register that are affected by
            folding in the trailing add insn.

    gcc/testsuite/ChangeLog:

            PR target/113089
            * gcc.c-torture/compile/pr113089.c: New test.

  parent reply	other threads:[~2024-01-23 16:51 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-20  3:12 [Bug target/113089] New: " hliu at amperecomputing dot com
2023-12-20  3:14 ` [Bug target/113089] " pinskia at gcc dot gnu.org
2023-12-20  8:02 ` rguenth at gcc dot gnu.org
2023-12-20 10:21 ` manolis.tsamis at vrull dot eu
2023-12-20 10:22 ` manolis.tsamis at vrull dot eu
2023-12-20 10:30 ` acoplan at gcc dot gnu.org
2023-12-20 10:44 ` acoplan at gcc dot gnu.org
2023-12-20 10:48 ` manolis.tsamis at vrull dot eu
2023-12-20 10:59 ` acoplan at gcc dot gnu.org
2023-12-20 11:03 ` manolis.tsamis at vrull dot eu
2023-12-20 11:05 ` acoplan at gcc dot gnu.org
2023-12-20 12:08 ` acoplan at gcc dot gnu.org
2024-01-08 12:51 ` jakub at gcc dot gnu.org
2024-01-18 15:08 ` acoplan at gcc dot gnu.org
2024-01-19  9:18 ` acoplan at gcc dot gnu.org
2024-01-23 16:50 ` cvs-commit at gcc dot gnu.org
2024-01-23 16:51 ` cvs-commit at gcc dot gnu.org
2024-01-23 16:51 ` cvs-commit at gcc dot gnu.org [this message]
2024-01-23 16:55 ` acoplan at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-113089-4-DBo5LcjTIP@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).