[Bug target/113093] New: [14 Regression][aarch64] ICE in rtl_verify_bb_insn, at cfgrtl.cc:2796 since r14-6605-gc0911c6b357ba9

[Bug target/113093] New: [14 Regression][aarch64] ICE in rtl_verify_bb_insn, at cfgrtl.cc:2796 since r14-6605-gc0911c6b357ba9

[mjires at suse dot cz]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113093

            Bug ID: 113093
           Summary: [14 Regression][aarch64] ICE in rtl_verify_bb_insn, at
                    cfgrtl.cc:2796 since r14-6605-gc0911c6b357ba9
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: mjires at suse dot cz
                CC: acoplan at gcc dot gnu.org
  Target Milestone: ---
            Target: aarch64

Compiling reduced testcase gcc.dg/compat/scalar-return-3_y.c results in ICE
since  r14-6605-gc0911c6b357ba9.

$ cat scalar-return-3_y.c
_Complex long *c;
void init() { *c = 1.0; }


$ aarch64-linux-gnu-gcc scalar-return-3_y.c -Os
-fharden-control-flow-redundancy -fnon-call-exceptions
scalar-return-3_y.c: In function ‘init’:
scalar-return-3_y.c:2:25: error: in basic block 2:
    2 | void init() { *c = 1.0; }
      |                         ^
scalar-return-3_y.c:2:25: error: flow control insn inside a basic block
(insn 12 11 66 2 (set (mem:V2x8QI (reg/f:DI 100 [ c.0_1 ]) [0 +0 S16 A64])
        (unspec:V2x8QI [
                (reg:DI 109)
                (const_int 0 [0])
            ] UNSPEC_STP)) "scalar-return-3_y.c":2:18 91 {*store_pair_8}
     (expr_list:REG_EH_REGION (const_int 1 [0x1])
        (nil)))
during RTL pass: ldp_fusion
scalar-return-3_y.c:2:25: internal compiler error: in rtl_verify_bb_insns, at
cfgrtl.cc:2802
0x16e5db4 _fatal_insn(char const*, rtx_def const*, char const*, int, char
const*)
        /home/mjires/git/GCC/master/gcc/rtl-error.cc:108
0x105e9d6 rtl_verify_bb_insns
        /home/mjires/git/GCC/master/gcc/cfgrtl.cc:2802
0x105ec9e rtl_verify_flow_info_1
        /home/mjires/git/GCC/master/gcc/cfgrtl.cc:2889
0x105f3fd rtl_verify_flow_info
        /home/mjires/git/GCC/master/gcc/cfgrtl.cc:3134
0x10448c2 verify_flow_info()
        /home/mjires/git/GCC/master/gcc/cfghooks.cc:283
0x103b2fa checking_verify_flow_info()
        /home/mjires/git/GCC/master/gcc/cfghooks.h:214
0x2956e01 try_optimize_cfg
        /home/mjires/git/GCC/master/gcc/cfgcleanup.cc:2980
0x29572da cleanup_cfg(int)
        /home/mjires/git/GCC/master/gcc/cfgcleanup.cc:3143
0x1e2bd7f ldp_fusion_destroy
       
/home/mjires/git/GCC/master/gcc/config/aarch64/aarch64-ldp-fusion.cc:2426
0x1e2cb02 ldp_fusion()
       
/home/mjires/git/GCC/master/gcc/config/aarch64/aarch64-ldp-fusion.cc:2650
0x1e2cbec execute
       
/home/mjires/git/GCC/master/gcc/config/aarch64/aarch64-ldp-fusion.cc:2698
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.


$ aarch64-linux-gnu-gcc -v
Using built-in specs.
COLLECT_GCC=aarch64-linux-gnu-gcc
COLLECT_LTO_WRAPPER=/home/mjires/built/master/libexec/gcc/aarch64-linux-gnu/14.0.0/lto-wrapper
Target: aarch64-linux-gnu
Configured with: /home/mjires/git/GCC/master/configure
--prefix=/home/mjires/built/master --target=aarch64-linux-gnu
--disable-bootstrap --enable-languages=c,c++,fortran --disable-multilib
--disable-libsanitizer --enable-checking : (reconfigured)
/home/mjires/git/GCC/master/configure --prefix=/home/mjires/built/master
--target=aarch64-linux-gnu --disable-bootstrap --enable-languages=c,c++,fortran
--disable-multilib --disable-libsanitizer --enable-checking
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 14.0.0 20231220 (experimental) (GCC)

[Bug target/113093] [14 Regression][aarch64] ICE in rtl_verify_bb_insn, at cfgrtl.cc:2796 since r14-6605-gc0911c6b357ba9

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113093

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |14.0

[Bug target/113093] [14 Regression][aarch64] ICE in rtl_verify_bb_insn, at cfgrtl.cc:2796 since r14-6605-gc0911c6b357ba9

[acoplan at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113093

Alex Coplan <acoplan at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2023-12-20
           Assignee|unassigned at gcc dot gnu.org      |acoplan at gcc dot gnu.org
             Status|UNCONFIRMED                 |ASSIGNED

--- Comment #1 from Alex Coplan <acoplan at gcc dot gnu.org> ---
Confirmed, I think the pass is missing logic to prevent moving throwing insns,
should be an easy fix.

[Bug target/113093] [14 Regression][aarch64] ICE in rtl_verify_bb_insn, at cfgrtl.cc:2796 since r14-6605-gc0911c6b357ba9

[acoplan at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113093

--- Comment #2 from Alex Coplan <acoplan at gcc dot gnu.org> ---
Testing a patch.

[Bug target/113093] [14 Regression][aarch64] ICE in rtl_verify_bb_insn, at cfgrtl.cc:2796 since r14-6605-gc0911c6b357ba9

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113093

--- Comment #3 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Alex Coplan <acoplan@gcc.gnu.org>:

https://gcc.gnu.org/g:aca1f9d7cab3dc1a374a7dc0ec6f7a8d02d2869a

commit r14-6784-gaca1f9d7cab3dc1a374a7dc0ec6f7a8d02d2869a
Author: Alex Coplan <alex.coplan@arm.com>
Date:   Thu Dec 21 10:52:44 2023 +0000

    aarch64: Prevent moving throwing accesses in ldp/stp pass [PR113093]

    As the PR shows, there was nothing to prevent the ldp/stp pass from
    trying to move throwing insns, which lead to an RTL verification
    failure.

    This patch fixes that.

    gcc/ChangeLog:

            PR target/113093
            * config/aarch64/aarch64-ldp-fusion.cc (latest_hazard_before):
            If the insn is throwing, record the previous insn as a hazard to
            prevent moving it from the end of the BB.

    gcc/testsuite/ChangeLog:

            PR target/113093
            * gcc.dg/pr113093.c: New test.

[Bug target/113093] [14 Regression][aarch64] ICE in rtl_verify_bb_insn, at cfgrtl.cc:2796 since r14-6605-gc0911c6b357ba9

[acoplan at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113093

Alex Coplan <acoplan at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Alex Coplan <acoplan at gcc dot gnu.org> ---
Should be fixed, thanks for the report.