public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "andysem at mail dot ru" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/113099] locale without RTTI uses dynamic_cast before gcc 13.2 or has ODR violation since gcc 13.2
Date: Sat, 23 Dec 2023 09:37:01 +0000	[thread overview]
Message-ID: <bug-113099-4-KCOE1qEK3M@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-113099-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113099

--- Comment #3 from andysem at mail dot ru ---
I think, a failing dynamic_cast would not be useful as this would make
std::use_facet unusable with -fno-rtti.

Re. ODR violation in the latest code, while it is true that the
dynamic/static_cast is not reachable for the standard facets, it is still part
of the function definition and the compiler is free to generate code that takes
it into account. Note that the shortcuts for the standard facets are
implemented with conditional if-constexpr, which will turn into regular ifs if
libstdc++ is compiled in pre-C++17 mode. Which, I think, is the default, isn't
it? I think, the ODR violation is still worth fixing.

  parent reply	other threads:[~2023-12-23  9:37 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-20 23:41 [Bug libstdc++/113099] New: " andysem at mail dot ru
2023-12-21  8:59 ` [Bug libstdc++/113099] " rguenth at gcc dot gnu.org
2023-12-21 21:49 ` redi at gcc dot gnu.org
2023-12-23  9:37 ` andysem at mail dot ru [this message]
2023-12-23  9:39 ` andysem at mail dot ru
2023-12-24 14:44 ` redi at gcc dot gnu.org
2023-12-24 14:46 ` redi at gcc dot gnu.org
2023-12-24 15:04 ` pdimov at gmail dot com
2023-12-24 15:27 ` redi at gcc dot gnu.org
2023-12-24 15:30 ` redi at gcc dot gnu.org
2023-12-24 15:40 ` pdimov at gmail dot com
2023-12-24 16:22 ` andysem at mail dot ru
2023-12-26 12:31 ` redi at gcc dot gnu.org
2023-12-26 15:20 ` andysem at mail dot ru
2024-01-03 12:38 ` redi at gcc dot gnu.org
2024-01-03 12:43 ` redi at gcc dot gnu.org
2024-01-05 10:23 ` cvs-commit at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-113099-4-KCOE1qEK3M@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).