public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "guojiufu at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/113109] [14 Regression] g++ EH tests fail at execution time for cris-elf after r14-6674-g4759383245ac97
Date: Sun, 24 Dec 2023 01:16:21 +0000	[thread overview]
Message-ID: <bug-113109-4-p3NuiB1nyu@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-113109-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113109

--- Comment #13 from Jiu Fu Guo <guojiufu at gcc dot gnu.org> ---
(In reply to GCC Commits from comment #9)
> The master branch has been updated by Hans-Peter Nilsson <hp@gcc.gnu.org>:
> 
> https://gcc.gnu.org/g:3d03630b123411340e52d05124cb0cacfa1fc8b0
> 
> commit r14-6817-g3d03630b123411340e52d05124cb0cacfa1fc8b0
> Author: Hans-Peter Nilsson <hp@axis.com>
> Date:   Sun Dec 24 00:10:32 2023 +0100
> 
>     CRIS: Fix PR middle-end/113109; "throw" failing
>     
>     TL;DR: the "dse1" pass removed the eh-return-address store.  The
>     PA also marks its EH_RETURN_HANDLER_RTX as volatile, for the same
>     reason, as does visum.  See PR32769 - it's the same thing on PA.
>     
>     Conceptually, it's logical that stores to incoming args are
>     optimized out on the return path or if no loads are seen -
>     at least before epilogue expansion, when the subsequent load
>     isn't seen in the RTL, as is the case for the "dse1" pass.

The stores to the argp/frame can be eliminated only if they are not used.
While for this case, the store may be used by EH handler, it should not be
optimized out. 

Thanks for catching and handling this quickly.

Happy holidays.

  parent reply	other threads:[~2023-12-24  1:16 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-22  2:12 [Bug middle-end/113109] New: " hp at gcc dot gnu.org
2023-12-22  2:22 ` [Bug middle-end/113109] " pinskia at gcc dot gnu.org
2023-12-22  2:24 ` pinskia at gcc dot gnu.org
2023-12-22  2:51 ` hp at gcc dot gnu.org
2023-12-23  2:42 ` hp at gcc dot gnu.org
2023-12-23  6:20 ` pinskia at gcc dot gnu.org
2023-12-23 17:19 ` hp at gcc dot gnu.org
2023-12-23 17:25 ` pinskia at gcc dot gnu.org
2023-12-24  0:19 ` guojiufu at gcc dot gnu.org
2023-12-24  0:34 ` guojiufu at gcc dot gnu.org
2023-12-24  0:41 ` cvs-commit at gcc dot gnu.org
2023-12-24  0:58 ` hp at gcc dot gnu.org
2023-12-24  1:01 ` hp at gcc dot gnu.org
2023-12-24  1:01 ` hp at gcc dot gnu.org
2023-12-24  1:16 ` guojiufu at gcc dot gnu.org [this message]
2023-12-24  9:13 ` hp at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-113109-4-p3NuiB1nyu@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).