public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "hp at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/113109] [14 Regression] g++ EH tests fail at execution time for cris-elf after r14-6674-g4759383245ac97
Date: Sun, 24 Dec 2023 00:58:45 +0000	[thread overview]
Message-ID: <bug-113109-4-zViOGEymjq@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-113109-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113109

--- Comment #10 from Hans-Peter Nilsson <hp at gcc dot gnu.org> ---
(In reply to Andrew Pinski from comment #6)
> So I did a quick audit of the EH_RETURN_HANDLER_RTX

Yeah, me too.

> and most are registers
> rather than a memory location  . And the ones which were memory locations
> used either frame or stack pointer directly which seemed to not to be
> removed.

And those that with an address relative to hard_frame_pointer_rtx, marks the
mem as volatile.

> I had originally was going to record my findings but then I saw the
> volatile for pa risc and deleted what I had wrote up.

Ouch, "never delete what you can't undo".  Sometimes you turn back another 180
degrees from your 180 turn in the middle of the analysis or bug-hunt.  Was it
more than a list of targets and their EH macros and patterns?

The fun thing is that the dse1 pass (the culprit) works before pro/epilogue
expansion, so it sees stores without the matching loads.  That is, for targets
that just define EH_RETURN_HANDLER_RTX (no eh_return pattern or any fancy
extra) and handles EH at epilogue expansion time.

  parent reply	other threads:[~2023-12-24  0:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-22  2:12 [Bug middle-end/113109] New: " hp at gcc dot gnu.org
2023-12-22  2:22 ` [Bug middle-end/113109] " pinskia at gcc dot gnu.org
2023-12-22  2:24 ` pinskia at gcc dot gnu.org
2023-12-22  2:51 ` hp at gcc dot gnu.org
2023-12-23  2:42 ` hp at gcc dot gnu.org
2023-12-23  6:20 ` pinskia at gcc dot gnu.org
2023-12-23 17:19 ` hp at gcc dot gnu.org
2023-12-23 17:25 ` pinskia at gcc dot gnu.org
2023-12-24  0:19 ` guojiufu at gcc dot gnu.org
2023-12-24  0:34 ` guojiufu at gcc dot gnu.org
2023-12-24  0:41 ` cvs-commit at gcc dot gnu.org
2023-12-24  0:58 ` hp at gcc dot gnu.org [this message]
2023-12-24  1:01 ` hp at gcc dot gnu.org
2023-12-24  1:01 ` hp at gcc dot gnu.org
2023-12-24  1:16 ` guojiufu at gcc dot gnu.org
2023-12-24  9:13 ` hp at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-113109-4-zViOGEymjq@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).