public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/113119] ICE: verify_ssa failed: definition in block 18 does not dominate use in block 4 at -O1 with _BitInt
Date: Fri, 22 Dec 2023 21:04:03 +0000	[thread overview]
Message-ID: <bug-113119-4-C4TaHoWBAg@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-113119-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113119

--- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Without the second redundant __builtin_add_overflow, we get
  a.0_1 = a;
  _7 = .ADD_OVERFLOW (a.0_1, 0);
  _2 = REALPART_EXPR <_7>;
  _3 = IMAGPART_EXPR <_7>;
  _4 = (_Bool) _3;
  c = _4;
  _5 = (_BitInt(8)) _2;
  b = _5;
before bitint lowering and lower it well, but the redundant call results in
  a.0_1 = a;
  _7 = .ADD_OVERFLOW (a.0_1, 0);
  _2 = IMAGPART_EXPR <_7>;
  _3 = (_Bool) _2;
  c = _3;
  _4 = REALPART_EXPR <_7>;
  _5 = (_BitInt(8)) _4;
  b = _5;
and optimizable_arith_overflow doesn't flag that as non-optimizable, so
the bitint lowering of .ADD_OVERFLOW happens in that case on the REALPART_EXPR
stmt.
optimizable_arith_overflow checks if both REALPART_EXPR and IMAGPART_EXPR
appear in the same bb (and that there are no other uses), but doesn't check
that REALPART_EXPR is first.  Either it should check that or perhaps allow it
first but require that it is not used in statements before the REALPART_EXPR.

  reply	other threads:[~2023-12-22 21:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-22 18:54 [Bug tree-optimization/113119] New: " zsojka at seznam dot cz
2023-12-22 21:04 ` jakub at gcc dot gnu.org [this message]
2023-12-23  7:41 ` [Bug tree-optimization/113119] " zsojka at seznam dot cz
2023-12-23  9:50 ` jakub at gcc dot gnu.org
2024-01-08 13:00 ` cvs-commit at gcc dot gnu.org
2024-01-08 13:02 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-113119-4-C4TaHoWBAg@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).