From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 963083857C4B; Wed, 10 Jan 2024 12:54:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 963083857C4B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1704891282; bh=ifcsEhCmqk/7FFeoFFQ7QvQBKfrwl1PTY83CXoixpYU=; h=From:To:Subject:Date:In-Reply-To:References:From; b=pmcR5dCJu3lFLtNg4wZrn/0rBucpnLxn/J4Y1dy9Wk1gMLYVT9rnIk7hX7NAdY/qA aR9E2kt+Yb8cHMdvGu6MSY3v9m2az1WHgTve3Ost4pMOXKplN51MFDtnHvCNTcRnJ3 B0yQNYjESBcMpuUbaMZYGUsUJzlmfQQDVpAXhDjM= From: "cvs-commit at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/113144] [14 regression] ICE when building dpkg-1.21.15 in verify_dominators (error: dominator of 9 should be 48, not 12) Date: Wed, 10 Jan 2024 12:54:40 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: tree-optimization X-Bugzilla-Version: 14.0 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: cvs-commit at gcc dot gnu.org X-Bugzilla-Status: ASSIGNED X-Bugzilla-Resolution: X-Bugzilla-Priority: P1 X-Bugzilla-Assigned-To: tnfchris at gcc dot gnu.org X-Bugzilla-Target-Milestone: 14.0 X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D113144 --- Comment #16 from GCC Commits --- The master branch has been updated by Tamar Christina : https://gcc.gnu.org/g:9e7c77c7933b1bb0dd07214333e52a9a896fa349 commit r14-7101-g9e7c77c7933b1bb0dd07214333e52a9a896fa349 Author: Tamar Christina Date: Wed Jan 10 12:51:54 2024 +0000 middle-end: Fix dominators updates when peeling with multiple exits [PR113144] When we peel at_exit we are moving the new loop at the exit of the prev= ious loop. This means that the blocks outside the loop dat the previous loop used to dominate are no longer being dominated by it. The new dominators however are hard to predict since if the loop has multiple exits and all the exits are an "early" one then we always execute the scalar loop. In this case the scalar loop can completely dominate the new loo= p. If we later have skip_vector then there's an additional skip edge added that might change the dominators. The previous patch would force an update of all blocks reachable from t= he new exits. This one updates *only* blocks that we know the scalar exits dominated. For the examples this reduces the blocks to update from 18 to 3. gcc/ChangeLog: PR tree-optimization/113144 PR tree-optimization/113145 * tree-vect-loop-manip.cc (slpeel_tree_duplicate_loop_to_edge_c= fg): Update all BB that the original exits dominated. gcc/testsuite/ChangeLog: PR tree-optimization/113144 PR tree-optimization/113145 * gcc.dg/vect/vect-early-break_94-pr113144.c: New test.=