From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 8B381386F808; Thu, 11 Jan 2024 18:03:39 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8B381386F808
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1704996219;
	bh=LvSSNvsTgsnsE6aTVZPVolBp6vYPQdytIlghgayKUzA=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=BK9POyoKdQ5FxGF6VZdWao1EuxBCRlZXlawQgw8JU3+40zqrrVIJXuPbHcwdIO5h3
	 frWe5NKSyQFMyWdcONk0Qd4k0xStc17z6alU+R/aSDwYXGuBr/RxwwAHyn8DFlQ2LS
	 T70lXiMagqB8y9j8TXQkGokiZR0q3LNHTPkCD1xk=
From: "dave.anglin at bell dot net" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/113182] [14 Regression] FAIL:
 g++.dg/cpp0x/udlit-namespace.C  -std=c++14 execution test
Date: Thu, 11 Jan 2024 18:03:39 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: middle-end
X-Bugzilla-Version: 14.0
X-Bugzilla-Keywords: wrong-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: dave.anglin at bell dot net
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P1
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 14.0
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-113182-4-PVgEr3n7u2@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-113182-4@http.gcc.gnu.org/bugzilla/>
References: <bug-113182-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D113182

--- Comment #16 from dave.anglin at bell dot net ---
On 2024-01-11 12:37 p.m., jakub at gcc dot gnu.org wrote:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D113182
>
> --- Comment #14 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
> (In reply to John David Anglin from comment #13)
>> Although the patch fixes the udlit-namespace.C test, I think the patch
>> still isn't correct.  I think the code should use maybe_get_identifier
>> instead of get_identifier.  See assemble_name_resolve.
> Why do you think so?  When assemble_external_libcall is called, it calls
> get_identifier to make sure such an identifier exists.
get_identifier allocates a new identifier node if one doesn't exist.=C2=A0 =
While it
may not matter
much at this point, I don't think this code should be allocating new identi=
fier
nodes.
assemble_name_resolve avoids creating new nodes.
>
> Though, if the targetm.strip_name_encoding call is needed, it should be d=
one
> not just in process_pending_assemble_externals, but also in
> assemble_external_libcall.
Will look at.=