From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 65D5F3858005; Thu, 11 Jan 2024 17:37:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 65D5F3858005 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1704994644; bh=vZQMYevzL0o9uHjUMJ40dw3D/NENGXkUpZIxv7XEggI=; h=From:To:Subject:Date:In-Reply-To:References:From; b=xFunaThrthpTIZRBWvKUOtUK3KjrQGBqwPAu3rl5nMdpshU0a2fnYc9VRHkduw3G3 jJhjWHMoaSLO5X6gfR/vtRMK0gGvKXs6o7xD2VcUnN6hiBmrkigHNa2Yvd9jaxziE9 HtCKMGlMSYMv6yZ6Y168BNx9PA2W/Vzdg3Y/AFOA= From: "jakub at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug middle-end/113182] [14 Regression] FAIL: g++.dg/cpp0x/udlit-namespace.C -std=c++14 execution test Date: Thu, 11 Jan 2024 17:37:24 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: middle-end X-Bugzilla-Version: 14.0 X-Bugzilla-Keywords: wrong-code X-Bugzilla-Severity: normal X-Bugzilla-Who: jakub at gcc dot gnu.org X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: P1 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: 14.0 X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D113182 --- Comment #14 from Jakub Jelinek --- (In reply to John David Anglin from comment #13) > Although the patch fixes the udlit-namespace.C test, I think the patch > still isn't correct. I think the code should use maybe_get_identifier > instead of get_identifier. See assemble_name_resolve. Why do you think so? When assemble_external_libcall is called, it calls get_identifier to make sure such an identifier exists. Though, if the targetm.strip_name_encoding call is needed, it should be done not just in process_pending_assemble_externals, but also in assemble_external_libcall.=