[Bug middle-end/113212] New: expand_expr_real_2 first argument can be constified

[Bug middle-end/113212] New: expand_expr_real_2 first argument can be constified

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113212

            Bug ID: 113212
           Summary: expand_expr_real_2 first argument can be constified
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Keywords: internal-improvement
          Severity: normal
          Priority: P3
         Component: middle-end
          Assignee: pinskia at gcc dot gnu.org
          Reporter: pinskia at gcc dot gnu.org
  Target Milestone: ---

Filing this to remind myself to submit a patch for this when stage 1 opens up.

[Bug middle-end/113212] expand_expr_real_2 first argument can be constified

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113212

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2024-01-03
             Status|UNCONFIRMED                 |ASSIGNED
     Ever confirmed|0                           |1

[Bug middle-end/113212] expand_expr_real_2 first argument can be constified

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113212

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement

[Bug middle-end/113212] expand_expr_real_2 first argument can be constified

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113212

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://gcc.gnu.org/piperma
                   |                            |il/gcc-patches/2024-June/65
                   |                            |4612.html
           Keywords|                            |patch

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Patch posted:
https://gcc.gnu.org/pipermail/gcc-patches/2024-June/654612.html

[Bug middle-end/113212] expand_expr_real_2 first argument can be constified

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113212

--- Comment #2 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The trunk branch has been updated by Andrew Pinski <pinskia@gcc.gnu.org>:

https://gcc.gnu.org/g:d8a6de9e2b850b71712e89e8e6026e4ae6284766

commit r15-1305-gd8a6de9e2b850b71712e89e8e6026e4ae6284766
Author: Andrew Pinski <quic_apinski@quicinc.com>
Date:   Thu Jun 13 13:07:10 2024 -0700

    expand: constify sepops operand to expand_expr_real_2 and
expand_widen_pattern_expr [PR113212]

    While working on an expand patch back in January I noticed that
    the first argument (of sepops type) of expand_expr_real_2 could be
    constified as it was not to be touched by the function (nor should it be).
    There is code in internal-fn.cc that depends on expand_expr_real_2 not
touching
    the ops argument so constification makes this more obvious.

    Bootstrapped and tested on x86_64-linux-gnu with no regressions.

    gcc/ChangeLog:

            PR middle-end/113212
            * expr.h (const_seqpops): New typedef.
            (expand_expr_real_2): Constify the first argument.
            * optabs.cc (expand_widen_pattern_expr): Likewise.
            * optabs.h (expand_widen_pattern_expr): Likewise.
            * expr.cc (expand_expr_real_2):  Likewise
            (do_store_flag): Likewise. Remove incorrect store to ops->code.

    Signed-off-by: Andrew Pinski <quic_apinski@quicinc.com>

[Bug middle-end/113212] expand_expr_real_2 first argument can be constified

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113212

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |15.0
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Fixed.