public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/113217] [14 Regression][aarch64] ICE in rtl_verify_bb_insns, at cfgrtl.cc:2796 since r14-6605-gc0911c6b357ba9
Date: Fri, 05 Jan 2024 12:25:52 +0000	[thread overview]
Message-ID: <bug-113217-4-ZwRyRbaBhG@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-113217-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113217

--- Comment #6 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Alex Coplan <acoplan@gcc.gnu.org>:

https://gcc.gnu.org/g:4b67ec7ff5b1aa9b3b70e9b58afc594b890abeb0

commit r14-6947-g4b67ec7ff5b1aa9b3b70e9b58afc594b890abeb0
Author: Alex Coplan <alex.coplan@arm.com>
Date:   Fri Jan 5 12:25:00 2024 +0000

    aarch64: Further fix for throwing insns in ldp/stp pass [PR113217]

    As the PR shows, the fix in
    r14-6916-g057dc349021660c40699fb5c98fd9cac8e168653 was not complete.
    That fix was enough to stop us trying to move throwing accesses above
    nondebug insns, but due to this code in try_fuse_pair:

      // Placement strategy: push loads down and pull stores up, this should
      // help register pressure by reducing live ranges.
      if (load_p)
        range.first = range.last;
      else
        range.last = range.first;

    we would still try to move stores up above any debug insns that occurred
    immediately after the previous nondebug insn.  This patch fixes that by
    narrowing the move range in the case that the second access is throwing
    to exactly the range of that insn.

    Note that we still need the fix to latest_hazard_before mentioned above
    so as to ensure we select a suitable base and reject pairs if it isn't
    viable to form the pair at the end of the BB.

    gcc/ChangeLog:

            PR target/113217
            * config/aarch64/aarch64-ldp-fusion.cc
            (ldp_bb_info::try_fuse_pair): If the second access can throw,
            narrow the move range to exactly that insn.

    gcc/testsuite/ChangeLog:

            PR target/113217
            * g++.dg/pr113217.C: New test.

  parent reply	other threads:[~2024-01-05 12:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-03 15:29 [Bug target/113217] New: " mjires at suse dot cz
2024-01-03 17:21 ` [Bug target/113217] " pinskia at gcc dot gnu.org
2024-01-03 17:23 ` acoplan at gcc dot gnu.org
2024-01-03 17:29 ` pinskia at gcc dot gnu.org
2024-01-03 17:29 ` pinskia at gcc dot gnu.org
2024-01-04 10:36 ` acoplan at gcc dot gnu.org
2024-01-04 15:54 ` pinskia at gcc dot gnu.org
2024-01-05 12:25 ` cvs-commit at gcc dot gnu.org [this message]
2024-01-05 12:27 ` acoplan at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-113217-4-ZwRyRbaBhG@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).