From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 1672F3858CDA; Wed, 21 Feb 2024 11:12:57 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1672F3858CDA
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1708513977;
	bh=eaKgNr3tEtTx26HU/lSxefqHS9OI1VlgLDnXu/ZRFEM=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=V8xaEHij0Xr3QpTDrq7fguYBIeZbm3pMi/j6UlxV8016265tM9NMMoeJciSTy+O3Z
	 WX7VizSCcfaTzpNEZARlZLv7Jxqat4EN5Culu68hHCgQaACLcp3neNJXe6w5QFQ5BI
	 BunHHT4gBrDKNHE9goG9FZK0rfXN6P+HqFAbe3Dc=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/113220] [aarch64] ICE Segmentation fault with
 r14-6178-g8d29b7aca15133
Date: Wed, 21 Feb 2024 11:12:55 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 14.0
X-Bugzilla-Keywords: ice-on-valid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: rsandifo at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-113220-4-41Sh3qUdOb@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-113220-4@http.gcc.gnu.org/bugzilla/>
References: <bug-113220-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D113220

--- Comment #4 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The trunk branch has been updated by Richard Sandiford <rsandifo@gcc.gnu.or=
g>:

https://gcc.gnu.org/g:4f7d4a2cd26673887f45e994a2f367a5c8fcc691

commit r14-9097-g4f7d4a2cd26673887f45e994a2f367a5c8fcc691
Author: Richard Sandiford <richard.sandiford@arm.com>
Date:   Wed Feb 21 11:12:26 2024 +0000

    Allow mode-switching to introduce internal loops [PR113220]

    In this PR, the SME mode-switching code needs to insert a stack-probe
    loop for an alloca.  This patch allows the target to do that.

    There are two parts to it: allowing loops for insertions in blocks,
    and allowing them for insertions on edges.  The former can be handled
    entirely within mode-switching itself, by recording which blocks have
    had new branches inserted.  The latter requires an extension to
    commit_one_edge_insertion.

    I think the extension to commit_one_edge_insertion makes logical sense,
    since it already explicitly allows internal loops during RTL expansion.
    The single-block find_sub_basic_blocks is a relatively recent addition,
    so wouldn't have been available when the code was originally written.

    The patch also has a small and obvious fix to make the aarch64 emit
    hook cope with labels.

    I've added specific -fstack-clash-protection versions of all
    aarch64-sme.exp tests that previously failed because of this bug.
    I've also added -fno-stack-clash-protection to the original versions
    of these tests if they contain scans that assume no protection.

    gcc/
            PR target/113220
            * cfgrtl.cc (commit_one_edge_insertion): Handle sequences that
            contain jumps even if called after initial RTL expansion.
            * mode-switching.cc: Include cfgbuild.h.
            (optimize_mode_switching): Allow the sequence returned by the
            emit hook to contain internal jumps.  Record which blocks
            contain such jumps and split the blocks at the end.
            * config/aarch64/aarch64.cc (aarch64_mode_emit): Check for
            non-debug insns when scanning the sequence.

    gcc/testsuite/
            PR target/113220
            * gcc.target/aarch64/sme/call_sm_switch_5.c: Add
            -fno-stack-clash-protection.
            * gcc.target/aarch64/sme/call_sm_switch_5_scp.c: New test.
            * gcc.target/aarch64/sme/sibcall_6_scp.c: New test.
            * gcc.target/aarch64/sme/za_state_4.c: Add
            -fno-stack-clash-protection.
            * gcc.target/aarch64/sme/za_state_4_scp.c: New test.
            * gcc.target/aarch64/sme/za_state_5.c: Add
            -fno-stack-clash-protection.
            * gcc.target/aarch64/sme/za_state_5_scp.c: New test.=