public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/113225] bpf: attribute((kernel_helper)) adds inconsistent BTF extern function decl entry.
Date: Mon, 08 Jan 2024 18:36:04 +0000	[thread overview]
Message-ID: <bug-113225-4-rdYiRiHSDu@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-113225-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113225

--- Comment #1 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Cupertino Miranda <cupermir@gcc.gnu.org>:

https://gcc.gnu.org/g:dfc88fb51c1f9c26215adf6a308c18e23992cdd9

commit r14-7011-gdfc88fb51c1f9c26215adf6a308c18e23992cdd9
Author: Cupertino Miranda <cupertino.miranda@oracle.com>
Date:   Wed Jan 3 11:37:34 2024 +0000

    bpf: Correct BTF for kernel_helper attributed decls

    This patch fix a problem with kernel_helper attribute BTF information,
    which incorrectly generates BTF_KIND_FUNC entry.
    This BTF entry although accurate with traditional extern function
    declarations, once the function is attributed with kernel_helper, it is
    semantically incompatible of the kernel helpers in BPF infrastructure.

    gcc/ChangeLog:
            PR target/113225
            * btfout.cc (btf_collect_datasec): Skip creating BTF info for
            extern and kernel_helper attributed function decls.
    gcc/testsuite/ChangeLog:
            * gcc.target/bpf/attr-kernel-helper.c: New test.

  reply	other threads:[~2024-01-08 18:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-03 20:54 [Bug target/113225] New: bpf: attributekernel_helper function declarations create a BTF_FUNC_EXTERN cupertino.miranda at oracle dot com
2024-01-08 18:36 ` cvs-commit at gcc dot gnu.org [this message]
2024-01-09 16:46 ` [Bug target/113225] bpf: attribute((kernel_helper)) adds inconsistent BTF extern function decl entry jemarch at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-113225-4-rdYiRiHSDu@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).