public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug middle-end/113228] [14 Regression] ICE: recalculate_side_effects, at gimplify.cc:3347 Date: Thu, 04 Jan 2024 04:19:20 +0000 [thread overview] Message-ID: <bug-113228-4-ltnqhWiO7x@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-113228-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113228 --- Comment #6 from Andrew Pinski <pinskia at gcc dot gnu.org> --- What match is doing is correct, what reassoc is doing looks to be ok, but the gimplifier just falls over on `SSA_NAME != 0`. This fixes the ICE but I don't understand how the gimplifier was handling SSA_NAME before if it ever was, the code mentioned here has not changed since the tuples was merged in: ``` diff --git a/gcc/gimplify.cc b/gcc/gimplify.cc index 15b540646c2..0cbe159b383 100644 --- a/gcc/gimplify.cc +++ b/gcc/gimplify.cc @@ -3304,6 +3304,9 @@ recalculate_side_effects (tree t) int len = TREE_OPERAND_LENGTH (t); int i; + if (code == SSA_NAME) + return; + switch (TREE_CODE_CLASS (code)) { case tcc_expression: @@ -18253,7 +18256,7 @@ gimplify_expr (tree *expr_p, gimple_seq *pre_p, gimple_seq *post_p, case SSA_NAME: /* Allow callbacks into the gimplifier during optimization. */ ret = GS_ALL_DONE; - break; + goto dont_recalculate; case OMP_PARALLEL: gimplify_omp_parallel (expr_p, pre_p); ```
next prev parent reply other threads:[~2024-01-04 4:19 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-01-04 2:42 [Bug middle-end/113228] New: " patrick at rivosinc dot com 2024-01-04 2:43 ` [Bug middle-end/113228] " patrick at rivosinc dot com 2024-01-04 2:51 ` pinskia at gcc dot gnu.org 2024-01-04 2:59 ` pinskia at gcc dot gnu.org 2024-01-04 3:02 ` pinskia at gcc dot gnu.org 2024-01-04 3:05 ` pinskia at gcc dot gnu.org 2024-01-04 3:28 ` pinskia at gcc dot gnu.org 2024-01-04 4:19 ` pinskia at gcc dot gnu.org [this message] 2024-01-04 5:48 ` pinskia at gcc dot gnu.org 2024-01-04 16:24 ` patrick at rivosinc dot com 2024-01-04 16:28 ` pinskia at gcc dot gnu.org 2024-01-04 16:33 ` patrick at rivosinc dot com 2024-01-05 11:31 ` [Bug middle-end/113228] [14 Regression] ICE: recalculate_side_effects, at gimplify.cc:3347 since r14-6420 jakub at gcc dot gnu.org 2024-01-05 12:06 ` jakub at gcc dot gnu.org 2024-01-05 12:38 ` jakub at gcc dot gnu.org 2024-01-05 22:29 ` pinskia at gcc dot gnu.org 2024-01-08 13:00 ` cvs-commit at gcc dot gnu.org 2024-01-08 13:01 ` jakub at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-113228-4-ltnqhWiO7x@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).