From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 5B4883858D38; Wed, 31 Jan 2024 23:28:26 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5B4883858D38
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1706743706;
	bh=ZHQ6Uaoteg+a8u7Del0ZQgn3wtBB04NI217RyUiVLg8=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=gKRqmtVSR3Owb8z0M4hBfNtD8IXK3irR/wGgcJIllVgGdGqTTYl+kIngx4VoNoBo3
	 roV67eL43Y7Te6pX4fdjldwzxmNv5lm/GfNq2dK8vt1yBtdHXHg/6/cQdKie8016g3
	 J0dRoJovPA4Bbk9m7lwj7XGX0x4+cD6XAOiFEQlE=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug analyzer/113253] gcc -g causes -fanalyzer to issue false
 positive
Date: Wed, 31 Jan 2024 23:28:26 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: analyzer
X-Bugzilla-Version: 13.2.1
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: dmalcolm at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-113253-4-tZaln16IwW@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-113253-4@http.gcc.gnu.org/bugzilla/>
References: <bug-113253-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D113253

--- Comment #3 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by David Malcolm <dmalcolm@gcc.gnu.org>:

https://gcc.gnu.org/g:cc7aebff74d8967563fd9af5cb958dfcc8c111e8

commit r14-8670-gcc7aebff74d8967563fd9af5cb958dfcc8c111e8
Author: David Malcolm <dmalcolm@redhat.com>
Date:   Wed Jan 31 18:26:26 2024 -0500

    analyzer: fix skipping of debug stmts [PR113253]

    PR analyzer/113253 reports a case where the analyzer output varied
    with and without -g enabled.

    The root cause was that debug stmts were in the
    FOR_EACH_IMM_USE_FAST list for SSA names, leading to the analyzer's
    state purging logic differing between the -g and non-debugging cases,
    and thus leading to differences in the exploration of the user's code.

    Fix by skipping such stmts in the state-purging logic, and removing
    debug stmts when constructing the supergraph.

    gcc/analyzer/ChangeLog:
            PR analyzer/113253
            * region-model.cc (region_model::on_stmt_pre): Add gcc_unreacha=
ble
            for debug statements.
            * state-purge.cc
            (state_purge_per_ssa_name::state_purge_per_ssa_name): Skip any
            debug stmts in the FOR_EACH_IMM_USE_FAST list.
            * supergraph.cc (supergraph::supergraph): Don't add debug stmts
            to the supernodes.

    gcc/testsuite/ChangeLog:
            PR analyzer/113253
            * gcc.dg/analyzer/deref-before-check-pr113253.c: New test.

    Signed-off-by: David Malcolm <dmalcolm@redhat.com>=