public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/113265] [Regression] Missed optimization for redundancy computation elimination may be due to constant propagation about 0 too late
Date: Tue, 09 Jan 2024 08:16:06 +0000	[thread overview]
Message-ID: <bug-113265-4-bHkSj5m2CK@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-113265-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113265

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rguenth at gcc dot gnu.org

--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
We have

 /* X / -X is -1.  */
 (simplify
   (div:C @0 (negate @0))
...

which doesn't use (negate_expr_p @0) but that wouldn't help because

(match negate_expr_p
 (minus @0 @1)
 (if ((ANY_INTEGRAL_TYPE_P (type) && TYPE_OVERFLOW_WRAPS (type))
      || (FLOAT_TYPE_P (type)
          && !HONOR_SIGN_DEPENDENT_ROUNDING (type)
          && !HONOR_SIGNED_ZEROS (type)))))

as (a - b) might be INT_MIN which we can't negate w/o invoking undefined
behavior.  We also don't have (negate_expr_p @0), a way to match the
then negated form.

VN might come to the rescue to turn b - a to -(a - b) if that is available.

  parent reply	other threads:[~2024-01-09  8:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-08  8:25 [Bug tree-optimization/113265] New: " 652023330028 at smail dot nju.edu.cn
2024-01-09  8:06 ` [Bug tree-optimization/113265] " rguenth at gcc dot gnu.org
2024-01-09  8:16 ` rguenth at gcc dot gnu.org [this message]
2024-01-09  8:43 ` pinskia at gcc dot gnu.org
2024-01-09 22:55 ` [Bug tree-optimization/113265] [11/12/13/14 Regression] " pinskia at gcc dot gnu.org
2024-01-09 23:01 ` pinskia at gcc dot gnu.org
2024-03-07 20:52 ` law at gcc dot gnu.org
2024-05-26  5:43 ` [Bug tree-optimization/113265] [11/12/13/14/15 " pinskia at gcc dot gnu.org
2024-05-26  5:44 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-113265-4-bHkSj5m2CK@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).