public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/113281] [11 Regression] Latent wrong code due to vectorization of shift reduction and missing promotions since r9-1590 Date: Wed, 26 Jun 2024 05:23:36 +0000 [thread overview] Message-ID: <bug-113281-4-T0sod1w6Td@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-113281-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113281 --- Comment #34 from GCC Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Alexandre Oliva <aoliva@gcc.gnu.org>: https://gcc.gnu.org/g:54d2339c9f87f702e02e571a5460e11c19e1c02f commit r15-1639-g54d2339c9f87f702e02e571a5460e11c19e1c02f Author: Alexandre Oliva <oliva@adacore.com> Date: Wed Jun 26 02:08:18 2024 -0300 [testsuite] [arm] [vect] adjust mve-vshr test [PR113281] The test was too optimistic, alas. We used to vectorize shifts by clamping the shift counts below the bit width of the types (e.g. at 15 for 16-bit vector elements), but (uint16_t)32768 >> (uint16_t)16 is well defined (because of promotion to 32-bit int) and must yield 0, not 1 (as before the fix). Unfortunately, in the gimple model of vector units, such large shift counts wouldn't be well-defined, so we won't vectorize such shifts any more, unless we can tell they're in range or undefined. So the test that expected the vectorization we no longer performed needs to be adjusted. Instead of nobbling the test, Richard Earnshaw suggested annotating the test with the expected ranges so as to enable the optimization, and Christophe Lyon suggested a further simplification. Co-Authored-By: Richard Earnshaw <Richard.Earnshaw@arm.com> for gcc/testsuite/ChangeLog PR tree-optimization/113281 * gcc.target/arm/simd/mve-vshr.c: Add expected ranges.
prev parent reply other threads:[~2024-06-26 5:23 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-01-08 19:17 [Bug target/113281] New: [14] RISC-V rv64gcv_zvl256b vector: Runtime mismatch with rv64gc patrick at rivosinc dot com 2024-01-08 19:20 ` [Bug target/113281] " patrick at rivosinc dot com 2024-01-08 21:49 ` rdapp at gcc dot gnu.org 2024-01-09 1:32 ` juzhe.zhong at rivai dot ai 2024-01-09 2:06 ` juzhe.zhong at rivai dot ai 2024-01-09 2:08 ` juzhe.zhong at rivai dot ai 2024-01-09 2:12 ` [Bug tree-optimization/113281] " pinskia at gcc dot gnu.org 2024-01-09 2:16 ` pinskia at gcc dot gnu.org 2024-01-09 2:17 ` juzhe.zhong at rivai dot ai 2024-01-09 2:58 ` [Bug tree-optimization/113281] [14 Regression] Wrong code due to vectorization of shift reduction and missing promotions pinskia at gcc dot gnu.org 2024-01-09 2:59 ` pinskia at gcc dot gnu.org 2024-01-09 8:32 ` rguenth at gcc dot gnu.org 2024-01-10 13:26 ` rguenth at gcc dot gnu.org 2024-01-12 12:16 ` cvs-commit at gcc dot gnu.org 2024-01-15 12:06 ` cvs-commit at gcc dot gnu.org 2024-01-23 16:58 ` [Bug tree-optimization/113281] [14 Regression] Wrong code due to vectorization of shift reduction and missing promotions since r14-3027 jakub at gcc dot gnu.org 2024-01-24 7:48 ` rguenth at gcc dot gnu.org 2024-01-24 7:54 ` pinskia at gcc dot gnu.org 2024-01-24 8:32 ` rguenther at suse dot de 2024-01-24 8:38 ` pinskia at gcc dot gnu.org 2024-01-24 9:52 ` jakub at gcc dot gnu.org 2024-01-24 9:54 ` rguenther at suse dot de 2024-01-24 10:00 ` jakub at gcc dot gnu.org 2024-01-24 13:23 ` jakub at gcc dot gnu.org 2024-01-24 20:49 ` rsandifo at gcc dot gnu.org 2024-01-29 12:33 ` cvs-commit at gcc dot gnu.org 2024-01-29 12:34 ` [Bug tree-optimization/113281] " rsandifo at gcc dot gnu.org 2024-01-31 17:30 ` [Bug tree-optimization/113281] [11/12/13 Regression] Latent wrong code due to vectorization of shift reduction and missing promotions since r9-1590 jakub at gcc dot gnu.org 2024-03-13 20:17 ` ewlu at rivosinc dot com 2024-03-13 20:22 ` pinskia at gcc dot gnu.org 2024-03-13 20:29 ` patrick at rivosinc dot com 2024-03-13 23:18 ` juzhe.zhong at rivai dot ai 2024-05-31 8:12 ` rdapp at gcc dot gnu.org 2024-05-31 14:56 ` cvs-commit at gcc dot gnu.org 2024-06-04 7:48 ` [Bug tree-optimization/113281] [11/12 " cvs-commit at gcc dot gnu.org 2024-06-04 12:47 ` [Bug tree-optimization/113281] [11 " cvs-commit at gcc dot gnu.org 2024-06-04 12:49 ` rsandifo at gcc dot gnu.org 2024-06-26 5:23 ` cvs-commit at gcc dot gnu.org [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-113281-4-T0sod1w6Td@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).