public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "tnfchris at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/113287] wrong code with __builtin_mul_overflow_p() and _BitInt() with -O3 -msse4
Date: Tue, 09 Jan 2024 14:29:52 +0000	[thread overview]
Message-ID: <bug-113287-4-LWEBaa0tgk@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-113287-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113287

Tamar Christina <tnfchris at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |tnfchris at gcc dot gnu.org
   Last reconfirmed|                            |2024-01-09
     Ever confirmed|0                           |1

--- Comment #3 from Tamar Christina <tnfchris at gcc dot gnu.org> ---
I'll take it. Thanks :)

The key difference between the loop that aborts and the one that doesn't is
this:

The one that doesn't abort generates:

  mask_patt_21.17_45 = vect__5.16_43 != vect_cst__44;
  if (mask_patt_21.17_45 != { 0, 0, 0, 0 })
    goto <bb 19>; [5.50%]

and the one that does genertaes:

  mask_patt_72.30_100 = vect_cst__101 != vect__48.29_102;
  if (mask_patt_72.30_100 == { -1, -1, -1, -1 })
    goto <bb 23>; [20.00%]

This happens when the CFG in the loop is flipped, so the vectorizer is instead
asking for the target to check that all values are true instead of any.

Looking at ix86_expand_branch only one part of the branch does a XOR to account
for the difference.

So I'll first start looking whether the generated assembly is as expected.

  parent reply	other threads:[~2024-01-09 14:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-09  5:30 [Bug rtl-optimization/113287] New: " zsojka at seznam dot cz
2024-01-09 14:12 ` [Bug rtl-optimization/113287] " jakub at gcc dot gnu.org
2024-01-09 14:23 ` jakub at gcc dot gnu.org
2024-01-09 14:29 ` tnfchris at gcc dot gnu.org [this message]
2024-01-09 16:07 ` tnfchris at gcc dot gnu.org
2024-01-10 12:36 ` [Bug tree-optimization/113287] " tnfchris at gcc dot gnu.org
2024-01-10 14:32 ` cvs-commit at gcc dot gnu.org
2024-01-10 14:33 ` tnfchris at gcc dot gnu.org
2024-01-12 15:33 ` cvs-commit at gcc dot gnu.org
2024-01-13  9:48 ` cvs-commit at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-113287-4-LWEBaa0tgk@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).