public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "hubicka at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug ipa/113291] [14 Regression] compilation never (?) finishes with recursive always_inline functions at -O and above since r14-2172
Date: Wed, 14 Feb 2024 17:14:05 +0000	[thread overview]
Message-ID: <bug-113291-4-H7DRdugYLf@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-113291-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113291

--- Comment #6 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
Created attachment 57427
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=57427&action=edit
patch

The patch makes compilation to finish in reasonable time.
I ended up in need to dropping DISREGARD_INLINE_LIMITS in late inlining for
functions with self recursive always inlines, since these grow large quick and
even non-recursive inlining is too slow.  We also end up with quite ugly
diagnostics of form:

tt.c:13:1: error: inlining failed in call to ‘always_inline’ ‘f1’: --param
max-inline-insns-auto limit reached
   13 | f1 (void)
      | ^~
tt.c:17:3: note: called from here
   17 |   f1 ();
      |   ^~~~~
tt.c:6:1: error: inlining failed in call to ‘always_inline’ ‘f0’: --param
max-inline-insns-auto limit reached
    6 | f0 (void)
      | ^~
tt.c:16:3: note: called from here
   16 |   f0 ();
      |   ^~~~~
tt.c:13:1: error: inlining failed in call to ‘always_inline’ ‘f1’: --param
max-inline-insns-auto limit reached
   13 | f1 (void)
      | ^~
tt.c:15:3: note: called from here
   15 |   f1 ();
      |   ^~~~~
In function ‘f1’,
    inlined from ‘f0’ at tt.c:8:3,


which is quite large so I can not add it to a testuiste.  I will see if I can
reduce this even more.

  parent reply	other threads:[~2024-02-14 17:14 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-09 14:00 [Bug ipa/113291] New: [14 Regression] compilation never (?) finishes with recursive always_inline functions at -O and above zsojka at seznam dot cz
2024-01-09 17:55 ` [Bug ipa/113291] " pinskia at gcc dot gnu.org
2024-01-09 18:38 ` pinskia at gcc dot gnu.org
2024-01-10 13:15 ` [Bug ipa/113291] [14 Regression] compilation never (?) finishes with recursive always_inline functions at -O and above since r14-2172 jakub at gcc dot gnu.org
2024-01-11 12:14 ` rguenth at gcc dot gnu.org
2024-02-14 16:07 ` hubicka at gcc dot gnu.org
2024-02-14 16:26 ` hubicka at gcc dot gnu.org
2024-02-14 17:14 ` hubicka at gcc dot gnu.org [this message]
2024-03-26 10:41 ` rguenth at gcc dot gnu.org
2024-04-09  9:50 ` hubicka at gcc dot gnu.org
2024-04-18 13:42 ` law at gcc dot gnu.org
2024-05-07  7:43 ` [Bug ipa/113291] [14/15 " rguenth at gcc dot gnu.org
2024-05-14 10:59 ` cvs-commit at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-113291-4-H7DRdugYLf@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).