public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/113323] ICE: tree check: expected none of vector_type, have vector_type in bitint_precision_kind, at gimple-lower-bitint.cc:131 with _BitInt()
Date: Fri, 12 Jan 2024 10:21:28 +0000	[thread overview]
Message-ID: <bug-113323-4-AsVjq2qmny@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-113323-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113323

--- Comment #2 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:a2d66158541c0923620b044098bf66a73b51c463

commit r14-7180-ga2d66158541c0923620b044098bf66a73b51c463
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Fri Jan 12 11:20:40 2024 +0100

    lower-bitint: Fix a typo in a condition [PR113323]

    The following testcase revealed a typo in condition, as the comment
    says the intent is
           /*  If lhs of stmt is large/huge _BitInt SSA_NAME not in m_names
               it means it will be handled in a loop or straight line code
               at the location of its (ultimate) immediate use, so for
               vop checking purposes check these only at the ultimate
               immediate use.  */
    but the condition was using != BITINT_TYPE rather than == BITINT_TYPE,
    so e.g. it used bitint_precision_kind on non-BITINT_TYPEs (e.g. on vector
    types it will crash because TYPE_PRECISION means something different there,
    or on say INTEGER_TYPEs the precision will never be large enough to be >=
    bitint_prec_large).

    The following patch fixes that.

    2024-01-12  Jakub Jelinek  <jakub@redhat.com>

            PR tree-optimization/113323
            * gimple-lower-bitint.cc (bitint_dom_walker::before_dom_children):
Fix
            check for lhs being large/huge _BitInt not in m_names.

            * gcc.dg/bitint-68.c: New test.

  parent reply	other threads:[~2024-01-12 10:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-11  5:33 [Bug tree-optimization/113323] New: " zsojka at seznam dot cz
2024-01-11 13:43 ` [Bug tree-optimization/113323] " jakub at gcc dot gnu.org
2024-01-12 10:21 ` cvs-commit at gcc dot gnu.org [this message]
2024-01-12 10:27 ` jakub at gcc dot gnu.org
2024-01-20 17:08 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-113323-4-AsVjq2qmny@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).