From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 1F72A385E452; Wed, 14 Feb 2024 15:21:09 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1F72A385E452
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1707924069;
	bh=7N+e4ePJW1phQsUnKNS7rj2rbwVUMjx4vh301Qxb27g=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=MHYqjX1A+kQ7BPdmSTECxfYhe0K68lZVlxd2ePs1BZwjkxjbE8lmGKhlA/FT7y8WK
	 AjfLo1iBg8rRKtNZz+NIiI6/hUatqihx/jDxmgpgulsR3mN3QjoLH+zIjA//EQxgNv
	 GKNCp01n7YqUgRNzhV0WxoumdFbL59d4yutSycKE=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/113332] [12/13/14 regression] checking ICE when building
 fcitx-5.1.6
Date: Wed, 14 Feb 2024 15:21:06 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 14.0
X-Bugzilla-Keywords: ice-checking, ice-on-valid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 12.4
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-113332-4-fR23RS0nW5@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-113332-4@http.gcc.gnu.org/bugzilla/>
References: <bug-113332-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D113332

--- Comment #5 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Patrick Palka <ppalka@gcc.gnu.org>:

https://gcc.gnu.org/g:9bc6b23d11697545e8a951ccd60691b1e58b98c2

commit r14-8981-g9bc6b23d11697545e8a951ccd60691b1e58b98c2
Author: Patrick Palka <ppalka@redhat.com>
Date:   Wed Feb 14 10:20:31 2024 -0500

    c++: synthesized_method_walk context independence [PR113908]

    In the second testcase below, during ahead of time checking of the
    non-dependent new-expr we synthesize B's copy ctor, which we expect to
    get defined as deleted since A's copy ctor is inaccessible.  But during
    access checking thereof, enforce_access incorrectly decides to defer it
    since we're in a template context according to current_template_parms
    (before r14-557 it checked processing_template_decl which got cleared
    from implicitly_declare_fn), which leads to the access check leaking out
    to the template context that triggered the synthesization, and B's copy
    ctor getting declared as non-deleted.

    This patch fixes this by using maybe_push_to_top_level to clear the
    context (including current_template_parms) before proceeding with the
    synthesization.  We could do this from implicitly_declare_fn, but it's
    better to do it more generally from synthesized_method_walk for sake of
    its other callers.

    This turns out to fix PR113332 as well: there the lambda context
    triggering synthesization was causing maybe_dummy_object to misbehave,
    but now synthesization is sufficiently context-independent.

            PR c++/113908
            PR c++/113332

    gcc/cp/ChangeLog:

            * method.cc (synthesized_method_walk): Use maybe_push_to_top_le=
vel.

    gcc/testsuite/ChangeLog:

            * g++.dg/cpp0x/lambda/lambda-nsdmi11.C: New test.
            * g++.dg/template/non-dependent31.C: New test.

    Reviewed-by: Jason Merrill <jason@redhat.com>=