From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 7AFAF3858D32; Fri, 12 Jan 2024 02:15:23 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7AFAF3858D32
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1705025723;
	bh=Inxxr8SHLcFlf/Daf4a8rptSFUW0UvYqP2Ys/Br41Kk=;
	h=From:To:Subject:Date:From;
	b=q4qHwzL1e04LPpYAwFp/YbgVAiskf920sV38hZ847h5UrY9gELw7Tg4+AV4zMz8zX
	 TGDzHAuGcjyuUElWYqTgckdyIGdaY/Rrmy0gSmjmfdpLwq0Qhlz4dOaikTxqzUEAf3
	 8AeDucyoA5bw9YBoZd3oOgCrduBvTaBal394UtKQ=
From: "liuhongt at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/113345] New: miss optimization for psign{b,w,d}.
Date: Fri, 12 Jan 2024 02:15:22 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 14.0
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: liuhongt at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status
 bug_severity priority component assigned_to reporter target_milestone
Message-ID: <bug-113345-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D113345

            Bug ID: 113345
           Summary: miss optimization for psign{b,w,d}.
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: liuhongt at gcc dot gnu.org
  Target Milestone: ---

void
foo (short* __restrict a, short* b, short* c)
{
    for (int i =3D 0; i !=3D 1000; i++)
      {
        a[i] =3D c[i] < 0 ? -b[i] : b[i];
      }
}

gcc -O2 -mavx2

foo(char*, char*, char*):
  xorl %eax, %eax
  vpxor %xmm2, %xmm2, %xmm2
.L2:
  vmovq (%rsi,%rax), %xmm0
  vmovq (%rdx,%rax), %xmm1
  vpsubb %xmm0, %xmm2, %xmm3
  vpcmpgtb %xmm1, %xmm2, %xmm1
  vpblendvb %xmm1, %xmm3, %xmm0, %xmm0
  vmovq %xmm0, (%rdi,%rax)
  addq $8, %rax
  cmpq $1000, %rax
  jne .L2
  ret

it can be optimized with psignw.


22115(define_insn "<ssse3_avx2>_psign<mode>3"
22116  [(set (match_operand:VI124_AVX2 0 "register_operand" "=3Dx,x")
22117        (unspec:VI124_AVX2
22118          [(match_operand:VI124_AVX2 1 "register_operand" "0,x")
22119           (match_operand:VI124_AVX2 2 "vector_operand" "xja,xjm")]
22120          UNSPEC_PSIGN))]


maybe we can just refactor the pattern as blow, then combine can generate t=
he
pattern for us.

22115(define_insn "<ssse3_avx2>_psign<mode>3"
22116  [(set (match_operand:VI124_AVX2 0 "register_operand" "=3Dx,x")
22117        (unspec:VI124_AVX2
22118          [(match_operand:VI124_AVX2 1 "register_operand" "0,x")
                (neg:VI124:(match_dup 1)
22119           (match_operand:VI124_AVX2 2 "vector_operand" "xja,xjm")]
22120          UNSPEC_PBLENDV))]=