* [Bug libstdc++/113376] Confusing notes when using C++17 parallel algorithms
2024-01-13 13:04 [Bug libstdc++/113376] New: Confusing notes when using C++17 parallel algorithms pilarlatiesa at gmail dot com
@ 2024-01-13 14:26 ` redi at gcc dot gnu.org
2024-01-15 8:50 ` pilarlatiesa at gmail dot com
` (10 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: redi at gcc dot gnu.org @ 2024-01-13 14:26 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113376
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Last reconfirmed| |2024-01-13
Ever confirmed|0 |1
Status|UNCONFIRMED |NEW
CC| |rodgertq at gcc dot gnu.org
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug libstdc++/113376] Confusing notes when using C++17 parallel algorithms
2024-01-13 13:04 [Bug libstdc++/113376] New: Confusing notes when using C++17 parallel algorithms pilarlatiesa at gmail dot com
2024-01-13 14:26 ` [Bug libstdc++/113376] " redi at gcc dot gnu.org
@ 2024-01-15 8:50 ` pilarlatiesa at gmail dot com
2024-01-15 10:17 ` redi at gcc dot gnu.org
` (9 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: pilarlatiesa at gmail dot com @ 2024-01-15 8:50 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113376
--- Comment #1 from Pilar Latiesa <pilarlatiesa at gmail dot com> ---
(In reply to Pilar Latiesa from comment #0)
> I don't understand why all these functions are even instantiated as they
> appear to be related to the vectorization of other algorithms.
Pragma messages are shown irrespectively of whether the function is
instantiated.
> i.e. is checking defined(_PSTL_USAGE_WARNINGS) instead of just
> _PSTL_USAGE_WARNINGS. This logic doesn't seem right.
This change was made as part of r14-2109-g3162ca09dbdc2e:
- #if _PSTL_USAGE_WARNINGS
+ #if defined(_PSTL_USAGE_WARNINGS)
I don’t think this change is correct.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug libstdc++/113376] Confusing notes when using C++17 parallel algorithms
2024-01-13 13:04 [Bug libstdc++/113376] New: Confusing notes when using C++17 parallel algorithms pilarlatiesa at gmail dot com
2024-01-13 14:26 ` [Bug libstdc++/113376] " redi at gcc dot gnu.org
2024-01-15 8:50 ` pilarlatiesa at gmail dot com
@ 2024-01-15 10:17 ` redi at gcc dot gnu.org
2024-01-15 15:13 ` pilarlatiesa at gmail dot com
` (8 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: redi at gcc dot gnu.org @ 2024-01-15 10:17 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113376
--- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> ---
(In reply to Pilar Latiesa from comment #1)
> (In reply to Pilar Latiesa from comment #0)
> > I don't understand why all these functions are even instantiated as they
> > appear to be related to the vectorization of other algorithms.
>
> Pragma messages are shown irrespectively of whether the function is
> instantiated.
Yeah, I don't know if Clang works differently (I don't think so?) or if those
pragmas are just misused. They come from the upstream PSTL project.
>
> > i.e. is checking defined(_PSTL_USAGE_WARNINGS) instead of just
> > _PSTL_USAGE_WARNINGS. This logic doesn't seem right.
>
> This change was made as part of r14-2109-g3162ca09dbdc2e:
>
> - #if _PSTL_USAGE_WARNINGS
> + #if defined(_PSTL_USAGE_WARNINGS)
>
> I don’t think this change is correct.
Good catch.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug libstdc++/113376] Confusing notes when using C++17 parallel algorithms
2024-01-13 13:04 [Bug libstdc++/113376] New: Confusing notes when using C++17 parallel algorithms pilarlatiesa at gmail dot com
` (2 preceding siblings ...)
2024-01-15 10:17 ` redi at gcc dot gnu.org
@ 2024-01-15 15:13 ` pilarlatiesa at gmail dot com
2024-01-15 16:05 ` redi at gcc dot gnu.org
` (7 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: pilarlatiesa at gmail dot com @ 2024-01-15 15:13 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113376
--- Comment #3 from Pilar Latiesa <pilarlatiesa at gmail dot com> ---
It seems that what is missing is a corresponding change in the macro definition
logic. It should have been changed to:
// Check the user-defined macro for warnings
#if defined(PSTL_USAGE_WARNINGS)
# define _PSTL_USAGE_WARNINGS
#endif
See
https://github.com/llvm/llvm-project/blob/5ccf19ded09f68bef43275c81c20b0e65f7c0b75/pstl/include/pstl/internal/pstl_config.h#L26
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug libstdc++/113376] Confusing notes when using C++17 parallel algorithms
2024-01-13 13:04 [Bug libstdc++/113376] New: Confusing notes when using C++17 parallel algorithms pilarlatiesa at gmail dot com
` (3 preceding siblings ...)
2024-01-15 15:13 ` pilarlatiesa at gmail dot com
@ 2024-01-15 16:05 ` redi at gcc dot gnu.org
2024-06-12 10:48 ` redi at gcc dot gnu.org
` (6 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: redi at gcc dot gnu.org @ 2024-01-15 16:05 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113376
--- Comment #4 from Jonathan Wakely <redi at gcc dot gnu.org> ---
https://github.com/llvm/llvm-project/commit/c4823cc5db69f16bb5c96cf7d1b0d070da83605e
changed the logic upstream, but it looks like that didn't come downstream with
r14-2109-g3162ca09dbdc2e
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug libstdc++/113376] Confusing notes when using C++17 parallel algorithms
2024-01-13 13:04 [Bug libstdc++/113376] New: Confusing notes when using C++17 parallel algorithms pilarlatiesa at gmail dot com
` (4 preceding siblings ...)
2024-01-15 16:05 ` redi at gcc dot gnu.org
@ 2024-06-12 10:48 ` redi at gcc dot gnu.org
2024-06-12 10:56 ` redi at gcc dot gnu.org
` (5 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: redi at gcc dot gnu.org @ 2024-06-12 10:48 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113376
--- Comment #5 from Jonathan Wakely <redi at gcc dot gnu.org> ---
I think
https://github.com/llvm/llvm-project/commit/3b9a1bb1af90db9472340ef2122d3855eb9ba3fc#r142768040
is the real cause of the problem. They wanted to avoid -Wundef errors, so
changed all the macro tests to use #ifdef instead of #if
That is what requires a change to how _PSTL_USAGE_WARNINGS is defined. It also
caused other problems elsewhere downstream:
https://github.com/oneapi-src/oneDPL/issues/1602
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug libstdc++/113376] Confusing notes when using C++17 parallel algorithms
2024-01-13 13:04 [Bug libstdc++/113376] New: Confusing notes when using C++17 parallel algorithms pilarlatiesa at gmail dot com
` (5 preceding siblings ...)
2024-06-12 10:48 ` redi at gcc dot gnu.org
@ 2024-06-12 10:56 ` redi at gcc dot gnu.org
2024-06-12 11:22 ` [Bug libstdc++/113376] [14/15 Regression] " redi at gcc dot gnu.org
` (4 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: redi at gcc dot gnu.org @ 2024-06-12 10:56 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113376
--- Comment #6 from Jonathan Wakely <redi at gcc dot gnu.org> ---
(In reply to Pilar Latiesa from comment #3)
> It seems that what is missing is a corresponding change in the macro
> definition logic. It should have been changed to:
>
> // Check the user-defined macro for warnings
> #if defined(PSTL_USAGE_WARNINGS)
> # define _PSTL_USAGE_WARNINGS
> #endif
>
> See
> https://github.com/llvm/llvm-project/blob/
> 5ccf19ded09f68bef43275c81c20b0e65f7c0b75/pstl/include/pstl/internal/
> pstl_config.h#L26
The upstream change breaks the previous API though.
It looks like users were able to define PSTL_USAGE_WARNINGS=0 or
PSTL_USAGE_WARNINGS=1 to request warnings to be off or on, respectively. But
the LLVM change means that it only matters whether it's defined or not. This
seems to have been a misguided change to make sure *all* macros are used with
#ifdef not #if. But that breaks the intended use for some of them.
So I think we should either revert the change later in the file which checks
_PSTL_USAGE_WARNINGS, or we should take the user-facing macro's value into
account when deciding whether to define it:
// Check the user-defined macro for warnings
#if defined(PSTL_USAGE_WARNINGS) && PSTL_USAGE_WARNINGS != 0
# define _PSTL_USAGE_WARNINGS
#endif
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug libstdc++/113376] [14/15 Regression] Confusing notes when using C++17 parallel algorithms
2024-01-13 13:04 [Bug libstdc++/113376] New: Confusing notes when using C++17 parallel algorithms pilarlatiesa at gmail dot com
` (6 preceding siblings ...)
2024-06-12 10:56 ` redi at gcc dot gnu.org
@ 2024-06-12 11:22 ` redi at gcc dot gnu.org
2024-06-12 20:40 ` redi at gcc dot gnu.org
` (3 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: redi at gcc dot gnu.org @ 2024-06-12 11:22 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113376
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Known to fail| |14.1.0, 15.0
Known to work| |13.3.0
Assignee|unassigned at gcc dot gnu.org |redi at gcc dot gnu.org
Target Milestone|--- |14.2
Summary|Confusing notes when using |[14/15 Regression]
|C++17 parallel algorithms |Confusing notes when using
| |C++17 parallel algorithms
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug libstdc++/113376] [14/15 Regression] Confusing notes when using C++17 parallel algorithms
2024-01-13 13:04 [Bug libstdc++/113376] New: Confusing notes when using C++17 parallel algorithms pilarlatiesa at gmail dot com
` (7 preceding siblings ...)
2024-06-12 11:22 ` [Bug libstdc++/113376] [14/15 Regression] " redi at gcc dot gnu.org
@ 2024-06-12 20:40 ` redi at gcc dot gnu.org
2024-06-13 13:10 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: redi at gcc dot gnu.org @ 2024-06-12 20:40 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113376
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
URL| |https://gcc.gnu.org/piperma
| |il/gcc-patches/2024-June/65
| |4411.html
Keywords| |patch
--- Comment #7 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Patch posted: https://gcc.gnu.org/pipermail/gcc-patches/2024-June/654411.html
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug libstdc++/113376] [14/15 Regression] Confusing notes when using C++17 parallel algorithms
2024-01-13 13:04 [Bug libstdc++/113376] New: Confusing notes when using C++17 parallel algorithms pilarlatiesa at gmail dot com
` (8 preceding siblings ...)
2024-06-12 20:40 ` redi at gcc dot gnu.org
@ 2024-06-13 13:10 ` cvs-commit at gcc dot gnu.org
2024-07-12 10:19 ` [Bug libstdc++/113376] [14 " cvs-commit at gcc dot gnu.org
2024-07-12 10:20 ` redi at gcc dot gnu.org
11 siblings, 0 replies; 13+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2024-06-13 13:10 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113376
--- Comment #8 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:
https://gcc.gnu.org/g:99a1fe6c12c733fe4923a75a79d09a66ff8abcec
commit r15-1255-g99a1fe6c12c733fe4923a75a79d09a66ff8abcec
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Wed Jun 12 16:47:17 2024 +0100
libstdc++: Fix unwanted #pragma messages from PSTL headers [PR113376]
When we rebased the PSTL on upstream, in r14-2109-g3162ca09dbdc2e, a
change to how _PSTL_USAGE_WARNINGS is set was missed out, but the change
to how it's tested was included. This means that the macro is always
defined, so testing it with #ifdef (instead of using #if to test its
value) doesn't work as intended.
Revert the test to use #if again, since that part of the upstream change
was unnecessary in the first place (the macro is always defined, so
there's no need to use #ifdef to avoid -Wundef warnings).
libstdc++-v3/ChangeLog:
PR libstdc++/113376
* include/pstl/pstl_config.h: Use #if instead of #ifdef to test
the _PSTL_USAGE_WARNINGS macro.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug libstdc++/113376] [14 Regression] Confusing notes when using C++17 parallel algorithms
2024-01-13 13:04 [Bug libstdc++/113376] New: Confusing notes when using C++17 parallel algorithms pilarlatiesa at gmail dot com
` (9 preceding siblings ...)
2024-06-13 13:10 ` cvs-commit at gcc dot gnu.org
@ 2024-07-12 10:19 ` cvs-commit at gcc dot gnu.org
2024-07-12 10:20 ` redi at gcc dot gnu.org
11 siblings, 0 replies; 13+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2024-07-12 10:19 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113376
--- Comment #9 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-14 branch has been updated by Jonathan Wakely
<redi@gcc.gnu.org>:
https://gcc.gnu.org/g:d920658cbb200729b7c2ad069fa4b6498e028ff1
commit r14-10413-gd920658cbb200729b7c2ad069fa4b6498e028ff1
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Wed Jun 12 16:47:17 2024 +0100
libstdc++: Fix unwanted #pragma messages from PSTL headers [PR113376]
When we rebased the PSTL on upstream, in r14-2109-g3162ca09dbdc2e, a
change to how _PSTL_USAGE_WARNINGS is set was missed out, but the change
to how it's tested was included. This means that the macro is always
defined, so testing it with #ifdef (instead of using #if to test its
value) doesn't work as intended.
Revert the test to use #if again, since that part of the upstream change
was unnecessary in the first place (the macro is always defined, so
there's no need to use #ifdef to avoid -Wundef warnings).
libstdc++-v3/ChangeLog:
PR libstdc++/113376
* include/pstl/pstl_config.h: Use #if instead of #ifdef to test
the _PSTL_USAGE_WARNINGS macro.
(cherry picked from commit 99a1fe6c12c733fe4923a75a79d09a66ff8abcec)
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug libstdc++/113376] [14 Regression] Confusing notes when using C++17 parallel algorithms
2024-01-13 13:04 [Bug libstdc++/113376] New: Confusing notes when using C++17 parallel algorithms pilarlatiesa at gmail dot com
` (10 preceding siblings ...)
2024-07-12 10:19 ` [Bug libstdc++/113376] [14 " cvs-commit at gcc dot gnu.org
@ 2024-07-12 10:20 ` redi at gcc dot gnu.org
11 siblings, 0 replies; 13+ messages in thread
From: redi at gcc dot gnu.org @ 2024-07-12 10:20 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113376
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
--- Comment #10 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Fixed for 14.2, thanks for the report and identifying the cause.
^ permalink raw reply [flat|nested] 13+ messages in thread