[Bug other/113399] New: -ffold-mem-offsets should not be a target option

[Bug other/113399] New: -ffold-mem-offsets should not be a target option

[gjl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113399

            Bug ID: 113399
           Summary: -ffold-mem-offsets should not be a target option
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: minor
          Priority: P3
         Component: other
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gjl at gcc dot gnu.org
  Target Milestone: ---

For some reason, -ffold-mem-offsets is a target option and displayed with
--help=target, which it shold not.

> grep -A3 mem-off common.opt
ffold-mem-offsets
Target Bool Var(flag_fold_mem_offsets) Init(1)
Fold instructions calculating memory offsets to the memory access instruction
if possible.

Added in r14-4664

[Bug other/113399] [14 Regression] -ffold-mem-offsets should not be a target option

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113399

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1
            Summary|-ffold-mem-offsets should   |[14 Regression]
                   |not be a target option      |-ffold-mem-offsets should
                   |                            |not be a target option
   Target Milestone|---                         |14.0

[Bug other/113399] [14 Regression] -ffold-mem-offsets should not be a target option

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113399

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
           Keywords|                            |diagnostic
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2024-01-15

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
confirmed

[Bug other/113399] [14 Regression] -ffold-mem-offsets should not be a target option

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113399

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Bet it should be Optimization instead of Target.

[Bug other/113399] [14 Regression] -ffold-mem-offsets should not be a target option

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113399

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
And Common

[Bug other/113399] [14 Regression] -ffold-mem-offsets should not be a target option

[law at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113399

--- Comment #4 from Jeffrey A. Law <law at gcc dot gnu.org> ---
Just something that was missed when this option was changed from target
dependent to target independent.  It definitely should not be a target option.

[Bug other/113399] [14 Regression] -ffold-mem-offsets should not be a target option

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113399

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Ok, I'll bootstrap/regtest:
2024-01-17  Jakub Jelinek  <jakub@redhat.com>

        PR other/113399
        * common.opt (ffold-mem-offset): Remove Target and Bool keywords, add
        Common and Optimization.

--- gcc/common.opt.jj   2024-01-03 11:51:31.467732078 +0100
+++ gcc/common.opt      2024-01-17 17:22:05.975424001 +0100
@@ -1262,7 +1262,7 @@ Common Var(flag_cprop_registers) Optimiz
 Perform a register copy-propagation optimization pass.

 ffold-mem-offsets
-Target Bool Var(flag_fold_mem_offsets) Init(1)
+Common Var(flag_fold_mem_offsets) Init(1) Optimization
 Fold instructions calculating memory offsets to the memory access instruction
if possible.

 fcrossjumping

The removal of Bool is for consistency, there are no other common.opt nor
*/*.opt options using it.

[Bug other/113399] [14 Regression] -ffold-mem-offsets should not be a target option

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113399

--- Comment #6 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:1203fc2e6a40c65896763554f62cacfb4bd6a836

commit r14-8208-g1203fc2e6a40c65896763554f62cacfb4bd6a836
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Thu Jan 18 08:45:09 2024 +0100

    opts: Fix up -ffold-mem-offsets option keywords

    While the option was originally meant to be a Target option for a single
    target, it is an option for all targets, so should be Common rather than
    Target, and because it is an optimization option which could be different
    in between different LTO TUs, I've added Optimization keyword too.
    From what I can see, Bool is a non-documented non-existing keyword (at
    least, grep Bool *.awk shows nothing, so I've dropped that too.  Seems
    that the option parsing simply parses and ignores any non-existing
keywords.

    Guess we should drop the Bool keywords from the gcc/config/riscv/riscv.opt
    file eventually, so that people don't copy this around.

    2024-01-18  Jakub Jelinek  <jakub@redhat.com>

            PR other/113399
            * common.opt (ffold-mem-offsets): Remove Target and Bool keywords,
add
            Common and Optimization.

[Bug other/113399] [14 Regression] -ffold-mem-offsets should not be a target option

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113399

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed.