public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libgcc/113402] Incorrect symbol versions for __builtin_nested_func_ptr_created, __builtin_nested_func_ptr in libgcc_s.so.1
Date: Thu, 01 Feb 2024 20:10:40 +0000	[thread overview]
Message-ID: <bug-113402-4-CSxKyDNydQ@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-113402-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113402

--- Comment #8 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:e9b2f15d989addc1c2ad4604f5fa5ee1bda6023b

commit r14-8712-ge9b2f15d989addc1c2ad4604f5fa5ee1bda6023b
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Thu Feb 1 21:07:01 2024 +0100

    libgcc: Avoid warnings on __gcc_nested_func_ptr_created [PR113402]

    I'm seeing hundreds of
    In file included from ../../../libgcc/libgcc2.c:56:
    ../../../libgcc/libgcc2.h:32:13: warning: conflicting types for built-in
function â__gcc_nested_func_ptr_createdâ; expected âvoid(void *, void *,
void *)â
    +[-Wbuiltin-declaration-mismatch]
       32 | extern void __gcc_nested_func_ptr_created (void *, void *, void
**);
          |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    warnings.

    Either we need to add like in r14-6218
      #pragma GCC diagnostic ignored "-Wbuiltin-declaration-mismatch"
    (but in that case because of the libgcc2.h prototype (why is it there?)
    it would need to be also with #pragma GCC diagnostic push/pop around),
    or we could go with just following how the builtins are prototyped on the
    compiler side and only cast to void ** when dereferencing (which is in
    a single spot in each TU).

    2024-02-01  Jakub Jelinek  <jakub@redhat.com>

            PR libgcc/113402
            * libgcc2.h (__gcc_nested_func_ptr_created): Change type of last
            argument from void ** to void *.
            * config/i386/heap-trampoline.c (__gcc_nested_func_ptr_created):
            Change type of dst from void ** to void * and cast dst to void **
            before dereferencing it.
            * config/aarch64/heap-trampoline.c (__gcc_nested_func_ptr_created):
            Likewise.

  parent reply	other threads:[~2024-02-01 20:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-15 16:38 [Bug libgcc/113402] New: Incorrect symbol versions for __builtin_nested_func_ptr_created, __builtin_nested_func_ptr fw at gcc dot gnu.org
2024-01-15 16:44 ` [Bug libgcc/113402] Incorrect symbol versions for __builtin_nested_func_ptr_created, __builtin_nested_func_ptr in libgcc_s.so.1 fw at gcc dot gnu.org
2024-01-15 17:00 ` jakub at gcc dot gnu.org
2024-01-15 20:30 ` iains at gcc dot gnu.org
2024-01-16  8:00 ` rguenth at gcc dot gnu.org
2024-01-28 11:00 ` cvs-commit at gcc dot gnu.org
2024-01-31 18:33 ` danglin at gcc dot gnu.org
2024-01-31 18:35 ` jakub at gcc dot gnu.org
2024-02-01 20:10 ` cvs-commit at gcc dot gnu.org [this message]
2024-03-17  2:47 ` iains at gcc dot gnu.org
2024-03-17 15:43 ` dave.anglin at bell dot net
2024-03-27 15:49 ` egallager at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-113402-4-CSxKyDNydQ@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).