From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 00C6A385841E; Tue, 23 Jan 2024 08:05:14 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 00C6A385841E
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1705997115;
	bh=uynKw80DV1lrv+IOSKKY1MuPlsxLkrKEp99EMLd51Lk=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=Oi2dE+Cz6Yav0Jvu8IspR4J8V3Gh7Fp59cQyoeMPvPAgGDf1CMai0YQ4MbE+V7Vbn
	 OhGkPuhE8OEAl3pXPPD/dvtIscA1OwzmyfQ02xY2MWoga+nQu2GcfDnV8s415yPeEb
	 fMYCMZkLeO2rtmhBBKYJPS/guh6Mh8XCbX6F6VqQ=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/113462] ICE: in handle_cast, at
 gimple-lower-bitint.cc:1539 at -O with _BitInt() in a struct
Date: Tue, 23 Jan 2024 08:05:14 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Version: 14.0
X-Bugzilla-Keywords: ice-on-valid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Resolution: FIXED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: jakub at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 14.0
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-113462-4-QLileKxoRL@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-113462-4@http.gcc.gnu.org/bugzilla/>
References: <bug-113462-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D113462

--- Comment #5 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:5015015ae6b29b3f1734c7693ba25b88cdd531a1

commit r14-8349-g5015015ae6b29b3f1734c7693ba25b88cdd531a1
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Jan 23 09:02:48 2024 +0100

    fold-const: Fold larger VIEW_CONVERT_EXPRs [PR113462]

    On Mon, Jan 22, 2024 at 11:27:52AM +0100, Richard Biener wrote:
    > We run into
    >
    > static tree
    > native_interpret_int (tree type, const unsigned char *ptr, int len)
    > {
    > ...
    >   if (total_bytes > len
    >       || total_bytes * BITS_PER_UNIT > HOST_BITS_PER_DOUBLE_INT)
    >     return NULL_TREE;
    >
    > OTOH using a V_C_E to "truncate" a _BitInt looks wrong?  OTOH the
    > check doesn't really handle native_encode_expr using the "proper"
    > wide_int encoding however that's exactly handled.  So it might be
    > a pre-existing issue that's only uncovered by large _BitInts
    > (__int128 might show similar issues?)

    I guess the || total_bytes * BITS_PER_UNIT > HOST_BITS_PER_DOUBLE_INT
    conditions make no sense, all we care is whether it fits in the buffer
    or not.
    But then there is
    fold_view_convert_expr
    (and other spots) which use
      /* We support up to 1024-bit values (for GCN/RISC-V V128QImode).  */
      unsigned char buffer[128];
    or something similar.
    This patch fixes even that by using a XALLOCAVEC allocated buffer
    if the type size is 129 .. 8192 bytes.

    2024-01-22  Jakub Jelinek  <jakub@redhat.com>

            PR tree-optimization/113462
            * fold-const.cc (native_interpret_int): Don't punt if total_byt=
es
            is larger than HOST_BITS_PER_DOUBLE_INT / BITS_PER_UNIT.
            (fold_view_convert_expr): Use XALLOCAVEC buffers for types with
            sizes between 129 and 8192 bytes.=