public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/113467] [14 regression] libgcrypt-1.10.3 is miscompiled
Date: Fri, 02 Feb 2024 23:56:06 +0000	[thread overview]
Message-ID: <bug-113467-4-NFLWicWvL3@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-113467-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113467

--- Comment #30 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tamar Christina <tnfchris@gcc.gnu.org>:

https://gcc.gnu.org/g:85094e2aa6dba7908f053046f02dd443e8f65d72

commit r14-8768-g85094e2aa6dba7908f053046f02dd443e8f65d72
Author: Tamar Christina <tamar.christina@arm.com>
Date:   Fri Feb 2 23:52:27 2024 +0000

    middle-end: check memory accesses in the destination block [PR113588].

    When analyzing loads for early break it was always the intention that for
the
    exit where things get moved to we only check the loads that can be reached
from
    the condition.

    However the main loop checks all loads and we skip the destination BB.  As
such
    we never actually check the loads reachable from the COND in the last BB
unless
    this BB was also the exit chosen by the vectorizer.

    This leads us to incorrectly vectorize the loop in the PR and in doing so
access
    out of bounds.

    gcc/ChangeLog:

            PR tree-optimization/113588
            PR tree-optimization/113467
            * tree-vect-data-refs.cc
            (vect_analyze_data_ref_dependence):  Choose correct dest and fix
checks.
            (vect_analyze_early_break_dependences): Update comments.

    gcc/testsuite/ChangeLog:

            PR tree-optimization/113588
            PR tree-optimization/113467
            * gcc.dg/vect/vect-early-break_108-pr113588.c: New test.
            * gcc.dg/vect/vect-early-break_109-pr113588.c: New test.

  parent reply	other threads:[~2024-02-02 23:56 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-18  5:21 [Bug tree-optimization/113467] New: " sjames at gcc dot gnu.org
2024-01-18  5:22 ` [Bug tree-optimization/113467] " sjames at gcc dot gnu.org
2024-01-18  5:23 ` sjames at gcc dot gnu.org
2024-01-18  5:23 ` sjames at gcc dot gnu.org
2024-01-18  5:24 ` sjames at gcc dot gnu.org
2024-01-18  5:46 ` sjames at gcc dot gnu.org
2024-01-18  6:53 ` sjames at gcc dot gnu.org
2024-01-18  8:22 ` rguenth at gcc dot gnu.org
2024-01-18  8:49 ` rguenth at gcc dot gnu.org
2024-01-18  8:51 ` rguenth at gcc dot gnu.org
2024-01-18  9:32 ` sjames at gcc dot gnu.org
2024-01-18  9:35 ` sjames at gcc dot gnu.org
2024-01-18 13:16 ` rguenth at gcc dot gnu.org
2024-01-18 16:47 ` sjames at gcc dot gnu.org
2024-01-19  2:31 ` sjames at gcc dot gnu.org
2024-01-19  3:00 ` sjames at gcc dot gnu.org
2024-01-19  7:06 ` rguenth at gcc dot gnu.org
2024-01-19 11:36 ` jakub at gcc dot gnu.org
2024-01-19 13:37 ` rguenth at gcc dot gnu.org
2024-01-23 16:11 ` sjames at gcc dot gnu.org
2024-01-23 17:06 ` tnfchris at gcc dot gnu.org
2024-01-23 17:42 ` rguenther at suse dot de
2024-01-23 17:47 ` tnfchris at gcc dot gnu.org
2024-01-24  7:32 ` rguenth at gcc dot gnu.org
2024-01-26 13:28 ` rguenth at gcc dot gnu.org
2024-01-26 13:33 ` sjames at gcc dot gnu.org
2024-01-26 13:44 ` sjames at gcc dot gnu.org
2024-01-26 14:04 ` tnfchris at gcc dot gnu.org
2024-01-26 19:45 ` kacper.slominski72 at gmail dot com
2024-01-29 18:09 ` tnfchris at gcc dot gnu.org
2024-01-30  8:01 ` sjames at gcc dot gnu.org
2024-02-01 21:56 ` sjames at gcc dot gnu.org
2024-02-02 23:56 ` cvs-commit at gcc dot gnu.org [this message]
2024-02-03 22:03 ` sjames at gcc dot gnu.org
2024-02-07 10:57 ` cvs-commit at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-113467-4-NFLWicWvL3@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).