public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug ipa/113490] [14 Regression] ICE: in propagate_vals_across_arith_jfunc, at ipa-cp.cc:2425 at -O3 since r14-285 Date: Wed, 24 Jan 2024 15:21:04 +0000 [thread overview] Message-ID: <bug-113490-4-Zv20qiikzI@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-113490-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113490 --- Comment #6 from GCC Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Martin Jambor <jamborm@gcc.gnu.org>: https://gcc.gnu.org/g:bc4a20bc57ce71da0a96bcc6ec5683640b9004d6 commit r14-8392-gbc4a20bc57ce71da0a96bcc6ec5683640b9004d6 Author: Martin Jambor <mjambor@suse.cz> Date: Wed Jan 24 16:19:48 2024 +0100 ipa-cp: Fix check for exceeding param_ipa_cp_value_list_size (PR 113490) When the check for exceeding param_ipa_cp_value_list_size limit was modified to be ignored for generating values from self-recursive calls, it should have been changed from equal to, to equals to or is greater than. This omission manifests itself as PR 113490. When I examined the condition I also noticed that the parameter should come from the callee rather than the caller, since the value list is associated with the former and not the latter. In practice the limit is of course very likely to be the same, but I fixed this aspect of the condition too. I briefly audited all other uses of opt_for_fn in ipa-cp.cc and all the others looked OK. gcc/ChangeLog: 2024-01-19 Martin Jambor <mjambor@suse.cz> PR ipa/113490 * ipa-cp.cc (ipcp_lattice<valtype>::add_value): Bail out if value count is equal or greater than the limit. Use the limit from the callee. gcc/testsuite/ChangeLog: 2024-01-22 Martin Jambor <mjambor@suse.cz> PR ipa/113490 * gcc.dg/ipa/pr113490.c: New test.
next prev parent reply other threads:[~2024-01-24 15:21 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-01-18 19:38 [Bug ipa/113490] New: [14 Regression] ICE: in propagate_vals_across_arith_jfunc, at ipa-cp.cc:2425 at -O3 zsojka at seznam dot cz 2024-01-18 19:44 ` [Bug ipa/113490] " pinskia at gcc dot gnu.org 2024-01-18 19:50 ` pinskia at gcc dot gnu.org 2024-01-19 8:57 ` rguenth at gcc dot gnu.org 2024-01-19 11:34 ` [Bug ipa/113490] [14 Regression] ICE: in propagate_vals_across_arith_jfunc, at ipa-cp.cc:2425 at -O3 since r14-285 jakub at gcc dot gnu.org 2024-01-19 12:15 ` jamborm at gcc dot gnu.org 2024-01-19 13:36 ` rguenth at gcc dot gnu.org 2024-01-20 20:53 ` jamborm at gcc dot gnu.org 2024-01-24 15:21 ` cvs-commit at gcc dot gnu.org [this message] 2024-01-24 15:24 ` jamborm at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-113490-4-Zv20qiikzI@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).