public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenther at suse dot de" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/113495] RISC-V: Time and memory awful consumption of SPEC2017 wrf benchmark
Date: Fri, 19 Jan 2024 10:22:23 +0000	[thread overview]
Message-ID: <bug-113495-4-BZNGW8V2Sw@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-113495-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113495

--- Comment #26 from rguenther at suse dot de <rguenther at suse dot de> ---
On Fri, 19 Jan 2024, juzhe.zhong at rivai dot ai wrote:

> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113495
> 
> --- Comment #22 from JuzheZhong <juzhe.zhong at rivai dot ai> ---
> (In reply to Richard Biener from comment #21)
> > I once tried to avoid df_reorganize_refs and/or optimize this with the
> > blocks involved but failed.
> 
> I am considering whether we should disable LICM for RISC-V by default if vector
> is enabled ?
> Since the compile time explode 10 times is really horrible.

I think that's a bad idea.  It only explodes for some degenerate cases.
The best would be to fix invariant motion to keep DF up-to-date so
it can stop using df_analyze_loop and instead analyze the whole function.
Or maybe change it to use the rtl-ssa framework instead.

There's already param_loop_invariant_max_bbs_in_loop:

  /* Process the loops, innermost first.  */
  for (auto loop : loops_list (cfun, LI_FROM_INNERMOST))
    {
      curr_loop = loop;
      /* move_single_loop_invariants for very large loops is time 
consuming
         and might need a lot of memory.  For -O1 only do loop invariant
         motion for very small loops.  */
      unsigned max_bbs = param_loop_invariant_max_bbs_in_loop;
      if (optimize < 2)
        max_bbs /= 10;
      if (loop->num_nodes <= max_bbs)
        move_single_loop_invariants (loop);
    }

it might be possible to restrict invariant motion to innermost loops
when the overall number of loops is too large (with a new param
for that).  And when the number of innermost loops also exceeds
the limit avoid even that?  The above also misses a
optimize_loop_for_speed_p (loop) check (probably doesn't make
a difference, but you could try).

  parent reply	other threads:[~2024-01-19 10:22 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-19  1:22 [Bug c/113495] New: " juzhe.zhong at rivai dot ai
2024-01-19  1:36 ` [Bug tree-optimization/113495] " juzhe.zhong at rivai dot ai
2024-01-19  1:38 ` juzhe.zhong at rivai dot ai
2024-01-19  1:48 ` juzhe.zhong at rivai dot ai
2024-01-19  1:52 ` juzhe.zhong at rivai dot ai
2024-01-19  1:55 ` [Bug rtl-optimization/113495] " pinskia at gcc dot gnu.org
2024-01-19  1:56 ` juzhe.zhong at rivai dot ai
2024-01-19  3:08 ` patrick at rivosinc dot com
2024-01-19  3:12 ` pinskia at gcc dot gnu.org
2024-01-19  3:14 ` pinskia at gcc dot gnu.org
2024-01-19  3:33 ` juzhe.zhong at rivai dot ai
2024-01-19  3:34 ` juzhe.zhong at rivai dot ai
2024-01-19  3:44 ` juzhe.zhong at rivai dot ai
2024-01-19  3:46 ` juzhe.zhong at rivai dot ai
2024-01-19  3:52 ` juzhe.zhong at rivai dot ai
2024-01-19  3:56 ` pinskia at gcc dot gnu.org
2024-01-19  3:58 ` juzhe.zhong at rivai dot ai
2024-01-19  4:00 ` juzhe.zhong at rivai dot ai
2024-01-19  8:23 ` juzhe.zhong at rivai dot ai
2024-01-19  8:41 ` juzhe.zhong at rivai dot ai
2024-01-19  9:23 ` rguenth at gcc dot gnu.org
2024-01-19  9:24 ` rguenth at gcc dot gnu.org
2024-01-19  9:28 ` juzhe.zhong at rivai dot ai
2024-01-19  9:35 ` kito at gcc dot gnu.org
2024-01-19 10:03 ` cvs-commit at gcc dot gnu.org
2024-01-19 10:05 ` juzhe.zhong at rivai dot ai
2024-01-19 10:22 ` rguenther at suse dot de [this message]
2024-01-22 11:42 ` rdapp at gcc dot gnu.org
2024-01-22 11:51 ` juzhe.zhong at rivai dot ai
2024-01-22 12:00 ` rguenth at gcc dot gnu.org
2024-01-22 13:21 ` juzhe.zhong at rivai dot ai
2024-01-22 15:04 ` juzhe.zhong at rivai dot ai
2024-01-24  0:30 ` cvs-commit at gcc dot gnu.org
2024-01-31  0:29 ` cvs-commit at gcc dot gnu.org
2024-01-31  1:25 ` juzhe.zhong at rivai dot ai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-113495-4-BZNGW8V2Sw@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).