public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug testsuite/113502] gcc.target/aarch64/vect-early-break-cbranch.c and gcc.target/aarch64/sve/vect-early-break-cbranch.c testcase are too sensitive
Date: Wed, 31 Jan 2024 14:53:06 +0000	[thread overview]
Message-ID: <bug-113502-4-Zm5dZW43Lo@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-113502-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113502

--- Comment #2 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tamar Christina <tnfchris@gcc.gnu.org>:

https://gcc.gnu.org/g:f7935beef7b02fbba0adf33fb2ba5c0a27d7e9ff

commit r14-8662-gf7935beef7b02fbba0adf33fb2ba5c0a27d7e9ff
Author: Tamar Christina <tamar.christina@arm.com>
Date:   Wed Jan 31 14:52:59 2024 +0000

    AArch64: relax cbranch tests to accepted inverted branches [PR113502]

    Recently something in the midend had started inverting the branches by
inverting
    the condition and the branches.

    While this is fine, it makes it hard to actually test.  In RTL I disable
    scheduling and BB reordering to prevent this.  But in GIMPLE there seems to
be
    nothing I can do.  __builtin_expect seems to have no impact on the change
since
    I suspect this is happening during expand where conditions can be flipped
    regardless of probability during compare_and_branch.

    Since the mid-end has plenty of correctness tests, this weakens the backend
    tests to just check that a correct looking sequence is emitted.

    gcc/testsuite/ChangeLog:

            PR testsuite/113502
            * gcc.target/aarch64/sve/vect-early-break-cbranch.c: Ignore exact
branch.
            * gcc.target/aarch64/vect-early-break-cbranch.c: Likewise.

  parent reply	other threads:[~2024-01-31 14:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-19 11:07 [Bug testsuite/113502] New: gcc.target/aarch64/vect-early-break-cbranch.c testcase is " pinskia at gcc dot gnu.org
2024-01-19 11:12 ` [Bug testsuite/113502] gcc.target/aarch64/vect-early-break-cbranch.c and gcc.target/aarch64/sve/vect-early-break-cbranch.c testcase are " pinskia at gcc dot gnu.org
2024-01-31 14:53 ` cvs-commit at gcc dot gnu.org [this message]
2024-01-31 14:55 ` tnfchris at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-113502-4-Zm5dZW43Lo@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).