public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rust/113553] rust fails to build on sparc64-linux-gnu
Date: Thu, 01 Feb 2024 20:03:34 +0000 [thread overview]
Message-ID: <bug-113553-4-wtTeJH6Ns8@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-113553-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113553
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://sourceware.org/bugz
| |illa/show_bug.cgi?id=31068
--- Comment #9 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Andrew Pinski from comment #6)
> > Some playing around showed that this fixes the problem for me:
> >
> > diff --git a/libiberty/pex-unix.c b/libiberty/pex-unix.c
> > index af98062a94c..a1d35820181 100644
> > --- a/libiberty/pex-unix.c
> > +++ b/libiberty/pex-unix.c
> > @@ -574,8 +574,8 @@ pex_unix_exec_child (struct pex_obj *obj
> > ATTRIBUTE_UNUSED,
> > {
> > int ret;
> > pid_t pid = -1;
> > - posix_spawnattr_t attr;
> > - posix_spawn_file_actions_t actions;
> > + static posix_spawnattr_t attr;
> > + static posix_spawn_file_actions_t actions;
> > int attr_initialized = 0, actions_initialized = 0;
> >
> > *err = 0;
>
> Let me look that seems like an unitialized variable. If it is obvious one, I
> will apply a patch.
So I looked into pex-unix.c and the code does the right thing:
ret = posix_spawnattr_init (&attr);
...
ret = posix_spawn_file_actions_init (&actions);
And looking into glibc we have just basically:
memset (attr, '\0', sizeof (*attr)); //__posix_spawnattr_init
memset (file_actions, '\0', sizeof (*file_actions)); //
__posix_spawn_file_actions_init
And that code has not changed in glibc for years (over 10) either.
So maybe memset is not working correctly.
oh look at this a memset issue on sparc glibc:
https://sourceware.org/bugzilla/show_bug.cgi?id=31068 .
next prev parent reply other threads:[~2024-02-01 20:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 8:15 [Bug rust/113553] New: rust fails to build on spar64-linux-gnu doko at gcc dot gnu.org
2024-01-24 14:33 ` [Bug rust/113553] rust fails to build on sparc64-linux-gnu ro at gcc dot gnu.org
2024-02-01 6:26 ` pinskia at gcc dot gnu.org
2024-02-01 11:40 ` doko at gcc dot gnu.org
2024-02-01 17:39 ` sjames at gcc dot gnu.org
2024-02-01 19:10 ` glaubitz at physik dot fu-berlin.de
2024-02-01 19:16 ` pinskia at gcc dot gnu.org
2024-02-01 19:18 ` sjames at gcc dot gnu.org
2024-02-01 19:54 ` glaubitz at physik dot fu-berlin.de
2024-02-01 20:03 ` pinskia at gcc dot gnu.org [this message]
2024-02-01 20:09 ` glaubitz at physik dot fu-berlin.de
2024-02-01 20:16 ` pinskia at gcc dot gnu.org
2024-02-02 8:39 ` bruno at clisp dot org
2024-02-02 8:43 ` pinskia at gcc dot gnu.org
2024-02-12 23:40 ` glaubitz at physik dot fu-berlin.de
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-113553-4-wtTeJH6Ns8@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).