public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/113607] [14] RISC-V rv64gcv vector: Runtime mismatch at -O3
Date: Wed, 31 Jan 2024 20:31:49 +0000	[thread overview]
Message-ID: <bug-113607-4-eZM48bmQhN@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-113607-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113607

--- Comment #24 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Robin Dapp <rdapp@gcc.gnu.org>:

https://gcc.gnu.org/g:8123f3ca3fd891034a8366518e756f161c4ff40d

commit r14-8668-g8123f3ca3fd891034a8366518e756f161c4ff40d
Author: Robin Dapp <rdapp@ventanamicro.com>
Date:   Tue Jan 30 18:39:08 2024 +0100

    match: Fix vcond into conditional op folding [PR113607].

    In PR113607 we see an invalid fold of

      _429 = .COND_SHL (mask_patt_205.47_276, vect_cst__262, vect_cst__262, {
0, ... });
      vect_prephitmp_129.51_282 = _429;
      vect_iftmp.55_287 = VEC_COND_EXPR <mask_patt_209.54_286,
vect_prephitmp_129.51_282, vect_cst__262>;

    to

      Applying pattern match.pd:9607, gimple-match-10.cc:3817
      gimple_simplified to vect_iftmp.55_287 = .COND_SHL (mask_patt_205.47_276,
vect_cst__262, vect_cst__262, { 0, ... });

    where we essentially use COND_SHL's else instead of VEC_COND_EXPR's.

    This patch adjusts the corresponding match.pd pattern and makes it only
    match when the else values are the same.

    That, however, causes the exact test case for which this pattern was
    introduced for to fail.  Therefore XFAIL it for now.

    gcc/ChangeLog:

            PR middle-end/113607

            * match.pd: Make sure else values match when folding a
            vec_cond into a conditional operation.

    gcc/testsuite/ChangeLog:

            * gcc.target/aarch64/sve/pre_cond_share_1.c: XFAIL.
            * gcc.target/riscv/rvv/autovec/pr113607-run.c: New test.
            * gcc.target/riscv/rvv/autovec/pr113607.c: New test.

  parent reply	other threads:[~2024-01-31 20:31 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-25 23:05 [Bug target/113607] New: " patrick at rivosinc dot com
2024-01-26  1:52 ` [Bug target/113607] " juzhe.zhong at rivai dot ai
2024-01-26  1:52 ` juzhe.zhong at rivai dot ai
2024-01-26  2:12 ` juzhe.zhong at rivai dot ai
2024-01-26  7:58 ` rdapp at gcc dot gnu.org
2024-01-26  8:05 ` patrick at rivosinc dot com
2024-01-26  8:12 ` patrick at rivosinc dot com
2024-01-26  8:14 ` rdapp at gcc dot gnu.org
2024-01-26  8:19 ` juzhe.zhong at rivai dot ai
2024-01-26  9:09 ` juzhe.zhong at rivai dot ai
2024-01-26  9:38 ` rdapp at gcc dot gnu.org
2024-01-26  9:42 ` juzhe.zhong at rivai dot ai
2024-01-26  9:42 ` pinskia at gcc dot gnu.org
2024-01-26  9:59 ` juzhe.zhong at rivai dot ai
2024-01-28  6:08 ` pinskia at gcc dot gnu.org
2024-01-29  3:27 ` juzhe.zhong at rivai dot ai
2024-01-29 12:29 ` rdapp at gcc dot gnu.org
2024-01-29 16:30 ` rdapp at gcc dot gnu.org
2024-01-29 19:50 ` rdapp at gcc dot gnu.org
2024-01-30 21:03 ` rdapp at gcc dot gnu.org
2024-01-30 22:12 ` juzhe.zhong at rivai dot ai
2024-01-30 22:14 ` pinskia at gcc dot gnu.org
2024-01-30 22:21 ` pinskia at gcc dot gnu.org
2024-01-31  8:28 ` rdapp at gcc dot gnu.org
2024-01-31 20:31 ` cvs-commit at gcc dot gnu.org [this message]
2024-02-02 18:20 ` [Bug middle-end/113607] " patrick at rivosinc dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-113607-4-eZM48bmQhN@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).