public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/113656] [x86] ICE in simplify_const_unary_operation, at simplify-rtx.cc:1954 with new -mavx10.1
Date: Wed, 31 Jan 2024 10:15:45 +0000	[thread overview]
Message-ID: <bug-113656-4-AB3eeQRD00@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-113656-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113656

--- Comment #7 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:b59775b642bb2b1ecd2e6d52c988b9c432117bc8

commit r14-8652-gb59775b642bb2b1ecd2e6d52c988b9c432117bc8
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Wed Jan 31 10:56:56 2024 +0100

    simplify-rtx: Fix up last argument to simplify_gen_unary [PR113656]

    When simplifying e.g. (float_truncate:SF (float_truncate:DF (reg:XF))
    or (float_truncate:SF (float_extend:XF (reg:DF)) etc. into
    (float_truncate:SF (reg:XF)) or (float_truncate:SF (reg:DF)) we call
    simplify_gen_unary with incorrect op_mode argument, it should be
    the argument's mode, but we call it with the outer mode instead.
    As these are all floating point operations, the argument always
    has non-VOIDmode and so we can just use that mode (as done in similar
    simplifications a few lines later), but neither FLOAT_TRUNCATE nor
    FLOAT_EXTEND are operations that should have the same modes of operand
    and result.  This bug hasn't been a problem for years because normally
    op_mode is used only if the mode of op is VOIDmode, otherwise it is
    redundant, but r10-2139 added an assertion in some spots that op_mode
    is right even in such cases.

    2024-01-31  Jakub Jelinek  <jakub@redhat.com>

            PR rtl-optimization/113656
            * simplify-rtx.cc (simplify_context::simplify_unary_operation_1)
            <case FLOAT_TRUNCATE>: Fix up last argument to simplify_gen_unary.

            * gcc.target/i386/pr113656.c: New test.

  parent reply	other threads:[~2024-01-31 10:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-29 15:49 [Bug target/113656] New: " mjires at suse dot cz
2024-01-30  2:50 ` [Bug target/113656] " haochen.jiang at intel dot com
2024-01-30  6:47 ` haochen.jiang at intel dot com
2024-01-30  6:49 ` haochen.jiang at intel dot com
2024-01-30  9:05 ` haochen.jiang at intel dot com
2024-01-30 11:23 ` liuhongt at gcc dot gnu.org
2024-01-30 18:35 ` jakub at gcc dot gnu.org
2024-01-30 18:41 ` [Bug rtl-optimization/113656] " jakub at gcc dot gnu.org
2024-01-31 10:15 ` cvs-commit at gcc dot gnu.org [this message]
2024-01-31 10:39 ` jakub at gcc dot gnu.org
2024-03-02  0:38 ` cvs-commit at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-113656-4-AB3eeQRD00@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).