From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 1C5BC3858282; Sat,  2 Mar 2024 00:38:56 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1C5BC3858282
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1709339936;
	bh=Iz7++maAFR5T7gyptlkL3ddaxkt2U2i6bJIL+IHAWgM=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=D+Gx6dg6bFdSTCQBwUIxuYNzLUAUUAiflGM4E9EIGdO8G64m50llZ0UykC2dHxOzO
	 5ZPAPBxpPu2YAaD6q5NPsqCCH8ry78PU+1FxzLsTGPRLbqVDiBzWOnIN+rpdONf2cy
	 vgjk10l+xePCZpUNBnDDCab54c5IdwfMKWkWO2Ws=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/113674] [11/12/13 Regression] [[____attr____]] causes
 internal compiler error: in decl_attributes, at attribs.cc:776
Date: Sat, 02 Mar 2024 00:38:54 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 14.0
X-Bugzilla-Keywords: ice-on-valid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: jakub at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 11.5
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-113674-4-oRkxspWMZl@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-113674-4@http.gcc.gnu.org/bugzilla/>
References: <bug-113674-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D113674

--- Comment #9 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:9de6ff5ec9a46951d2c71b5b32574a516a72b907

commit r13-8390-g9de6ff5ec9a46951d2c71b5b32574a516a72b907
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Mon Feb 12 20:45:01 2024 +0100

    attribs: Don't canonicalize lookup_scoped_attribute_spec argument
[PR113674]

    The C and C++ FEs when parsing attributes already canonicalize them
    (i.e. if they start with __ and end with __ substrings, we remove those=
).
    lookup_attribute already verifies in gcc_assert that the first character
    of name is not an underscore, and even lookup_scoped_attribute_spec doe=
sn't
    attempt to canonicalize the namespace it is passed.  But for some histo=
ric
    reason it was canonicalizing the name argument, which misbehaves when
    an attribute starts with ____ and ends with ____.
    I believe it is just wrong to try to canonicalize
    lookup_scope_attribute_spec name attribute, it should have been
    canonicalized already, in other spots where it is called it is already
    canonicalized before.

    2024-02-12  Jakub Jelinek  <jakub@redhat.com>

            PR c++/113674
            * attribs.cc (extract_attribute_substring): Remove.
            (lookup_scoped_attribute_spec): Don't call it.

            * c-c++-common/Wattributes-3.c: New test.

    (cherry picked from commit b42e978f29b33071addff6d7bb8bcdb11d176606)=