public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/113678] SLP misses up vec_concat
Date: Wed, 31 Jan 2024 08:32:14 +0000	[thread overview]
Message-ID: <bug-113678-4-PTcF8nAhIm@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-113678-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113678

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2024-01-31
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
I think the SLP tree we discover is sound:

t2.c:11:14: note:   node 0x5db76f0 (max_nunits=8, refcnt=2) vector(8) char
t2.c:11:14: note:   op template: *a_7(D) = _1;
t2.c:11:14: note:       stmt 0 *a_7(D) = _1;
t2.c:11:14: note:       stmt 1 MEM[(char *)a_7(D) + 1B] = _2;
t2.c:11:14: note:       stmt 2 MEM[(char *)a_7(D) + 2B] = _3;
t2.c:11:14: note:       stmt 3 MEM[(char *)a_7(D) + 3B] = _4;
t2.c:11:14: note:       stmt 4 MEM[(char *)a_7(D) + 4B] = _1;
t2.c:11:14: note:       stmt 5 MEM[(char *)a_7(D) + 5B] = _2;
t2.c:11:14: note:       stmt 6 MEM[(char *)a_7(D) + 6B] = _3;
t2.c:11:14: note:       stmt 7 MEM[(char *)a_7(D) + 7B] = _4;
t2.c:11:14: note:       children 0x5db7778
t2.c:11:14: note:   node 0x5db7778 (max_nunits=8, refcnt=2) vector(8) char
t2.c:11:14: note:   op template: _1 = *b_6(D);
t2.c:11:14: note:       stmt 0 _1 = *b_6(D);
t2.c:11:14: note:       stmt 1 _2 = MEM[(char *)b_6(D) + 1B];
t2.c:11:14: note:       stmt 2 _3 = MEM[(char *)b_6(D) + 2B];
t2.c:11:14: note:       stmt 3 _4 = MEM[(char *)b_6(D) + 3B];
t2.c:11:14: note:       stmt 4 _1 = *b_6(D);
t2.c:11:14: note:       stmt 5 _2 = MEM[(char *)b_6(D) + 1B];
t2.c:11:14: note:       stmt 6 _3 = MEM[(char *)b_6(D) + 2B];
t2.c:11:14: note:       stmt 7 _4 = MEM[(char *)b_6(D) + 3B];
t2.c:11:14: note:       load permutation { 0 1 2 3 0 1 2 3 }

the issue is as so often

t2.c:11:14: note:   ==> examining statement: _1 = *b_6(D);
t2.c:11:14: missed:   BB vectorization with gaps at the end of a load is not
supported
t2.c:3:19: missed:   not vectorized: relevant stmt not supported: _1 = *b_6(D);
t2.c:11:14: note:   Building vector operands of 0x5db7778 from scalars instead

where we are not applying much non-ad-hoc work to deal with those
"out-of-bound" accesses.  The choice here would be obvious in doing
a single vector(4) load instead.

  reply	other threads:[~2024-01-31  8:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-31  2:33 [Bug tree-optimization/113678] New: " pinskia at gcc dot gnu.org
2024-01-31  8:32 ` rguenth at gcc dot gnu.org [this message]
2024-02-06 17:14 ` [Bug tree-optimization/113678] " pinskia at gcc dot gnu.org
2024-02-06 17:46 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-113678-4-PTcF8nAhIm@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).